Support independent CPU and GPU workloads on the same node#331
Open
sacheendra wants to merge 9 commits intoatlarge-research:masterfrom
Open
Support independent CPU and GPU workloads on the same node#331sacheendra wants to merge 9 commits intoatlarge-research:masterfrom
sacheendra wants to merge 9 commits intoatlarge-research:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
=============================================
+ Coverage 0 54.80% +54.80%
- Complexity 0 52 +52
=============================================
Files 0 340 +340
Lines 0 11505 +11505
Branches 0 1139 +1139
=============================================
+ Hits 0 6305 +6305
- Misses 0 4845 +4845
- Partials 0 355 +355 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Worklaods can now run CPU and GPU tasks on each host.
The caveat is that the fragments for these tasks need to be independent.
Implementation Notes ⚒️
GPU is called accel in most places because CPU and GPU only differ by one letter, which can lead to more programming errors.
Using accel instead of GPU guards against that.
The fragments file can now have GPU fragments. These fragments have the is_gpu column set to true. When the flag is set the cpu_usage column is instead used as GPU usage.
The topology now has accel and accelPowerModel fields. The options for these are the same as those for the cpu and cpuPowerModel fields.
Check
gpu/single_1_2000.jsontopology file in experiments-base test resources for an example.The GPU (accel) implementation uses many classes with CPU in the name, as the required parameters are the same. For example, CpuPowerModel, HostCpuStats, etc. We can rename them to generalize better in the future.
External Dependencies 🍀
Breaking API Changes⚠️
Simply specify none (N/A) if not applicable.