Skip to content

[Atlassian] Issue of not using proxies inside rest client session #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2025
Merged

[Atlassian] Issue of not using proxies inside rest client session #1488

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cb7332
Add proxies to request session
flok Jan 13, 2025
fd538d9
Delete trailing whitespace
flok Jan 13, 2025
fa5d81c
Update rest_client.py
flok Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions atlassian/rest_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@
self._session = requests.Session()
else:
self._session = session

if proxies is not None:
self._session.proxies = self.proxies

Check warning on line 124 in atlassian/rest_client.py

View check run for this annotation

Codecov / codecov/patch

atlassian/rest_client.py#L124 

Added line #L124 was not covered by tests

if backoff_and_retry and int(urllib3.__version__.split(".")[0]) >= 2:
# Note: we only retry on status and not on any of the
# other supported reasons
Expand Down
Loading