Skip to content

fix(Confluence): method attach_file() to not read() file content #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025
Merged

fix(Confluence): method attach_file() to not read() file content #1535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions atlassian/confluence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1502,16 +1502,15 @@
content_type = self.content_types.get(extension, "application/binary")

with open(filename, "rb") as infile:
content = infile.read()
return self.attach_content(
content,
name,
content_type,
page_id=page_id,
title=title,
space=space,
comment=comment,
)
return self.attach_content(

Check warning on line 1505 in atlassian/confluence.py

View check run for this annotation

Codecov / codecov/patch

atlassian/confluence.py#L1505 

Added line #L1505 was not covered by tests
infile,
name,
content_type,
page_id=page_id,
title=title,
space=space,
comment=comment,
)

def download_attachments_from_page(self, page_id, path=None, start=0, limit=50, filename=None, to_memory=False):
"""
Expand Down