Merged
Conversation
In the JVM implementation, switch from synchronizedList to CopyOnWriteArrayList because synchronizedList can't handle iterators. Actually, the old implementation I did for ME-3981 used this. The notes I wrote at that time when I implemented this in MK; ``` /** * From some testing on mix-contents.json (will differ based on document etc.); * Initial Render: 3:1 interating (reads) vs writing * Selection: ~10:1 * Typing: ~5:1 * * Therefore, CopyOnWriteArrayList is probably preferable to synchronizing out traversals (w/synchronizedList), * despite the penalty of having to copy on write (the size is only 12 anyway). */ ```
tchernykh
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.