pass onKeyDown to Link component #256
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 476aae1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tomgasson
reviewed
Jun 5, 2025
| @@ -103,6 +104,7 @@ const Link = forwardRef<HTMLButtonElement | HTMLAnchorElement, LinkProps>( | |||
| const handleLinkPress = (e: MouseEvent | KeyboardEvent) => | |||
There was a problem hiding this comment.
nit: Given this is immediately split into keyboard vs non-keyboard inside handleNavigation, might as well just fully split this into two different things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current state:
onLinkPressed->handleNavigationwhich swallows the original onKeyDown.onLinkPressed->handleNavigationpr state:
handleNavigation(which one could argue we should handle in the Link component itself, but that was a little bit bigger of a refactor - which I can do if the team wants); when the key is not Enter, the onKeyDown will be fired.