AXON-1710 add replay analytics #1449
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwieger-atlassian-com
requested review from
Blastoplex,
amarg-at,
bhorai-atl,
cabella-dot,
ccallcottstevens,
dchiew-atl,
jwang19-atlassian,
marcomura,
matt-lassian,
mattcolman,
om-ukr,
sdzh-atlassian,
sspanchenko and
teg-atlassian
as code owners
![atlassian[bot]](https://avatars.githubusercontent.com/in/14320?s=60&v=4){kind=small}
Co-authored-by: atlassian[bot] <40802693+atlassian[bot]@users.noreply.github.com>
Co-authored-by: atlassian[bot] <40802693+atlassian[bot]@users.noreply.github.com>
bhorai-atl
force-pushed
the
no-ticket-add-replay-analytics
branch
from
4edb5c9 to
000ccaf
Compare
marcomura
reviewed
Jan 1, 2026
marcomura
reviewed
Jan 1, 2026
…tlassian/atlascode into no-ticket-add-replay-analytics
bwieger-atlassian-com
changed the title
Contributor
|
The issue is ready for review. The below acceptance criteria have not been met:
|
Contributor
|
The issue is ready for review. The below acceptance criteria have not been met:
Code Reviewer could not determine whether the following acceptance criteria have been met:
|
| } | ||
|
|
||
| // Emit analytics for replay completion | ||
| this._telemetryProvider.fireTelemetryEvent({ |
Contributor
There was a problem hiding this comment.
🔥 Code Bugs
The telemetry event is emitted before processing the replay response, which may not accurately reflect completion status if processRovoDevReplayResponse fails.
Details
📖 Explanation: Moving the telemetry emission after the replay processing would ensure the event only fires when the replay actually completes successfully, providing more accurate health monitoring data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This Change?
Problem statement: Sometimes, the replay behaves unusually. Ideally, we would see this quickly through our metrics vs waiting for users to report it.