AXON-1713: No users show up on the search list when using @mention #1467
+70
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sspanchenko
force-pushed
the
AXON-1713-no-users-show-up-in-the-search-list
branch
from
cdd0107 to
7326121
Compare
sspanchenko
force-pushed
the
AXON-1713-no-users-show-up-in-the-search-list
branch
from
7326121 to
bf2f377
Compare
sspanchenko
requested review from
Blastoplex,
amarg-at,
bhorai-atl,
bwieger-atlassian-com,
cabella-dot,
ccallcottstevens,
dchiew-atl,
jwang19-atlassian,
marcomura,
matt-lassian,
mattcolman,
om-ukr,
sdzh-atlassian and
teg-atlassian
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This Change?
Summary:
Fixed a regression where mentions (
@user) stopped working in Jira issue comments when using the legacy editor.Root cause:
A recent refactoring for the new Atlaskit Editor introduced an additional parameter to the user search function. This caused a conflict with the existing mention picker component, which resulted in malformed API requests and invalid data format being sent to Jira.
Impact:
Users were unable to mention colleagues in comments - the user list appeared empty, and manually typed mentions failed to post.
Resolution:
Corrected the data flow between components and ensured the WikiMarkup-to-ADF conversion produces valid output that Jira API accepts.
QA Demo:
https://www.loom.com/share/7c1ca96ede8742c0bad6447b858533b0
Source: #1333
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations: