Skip to content

fix: prevent markdown rendering error by ensuring string input#1612

Merged
Blastoplex merged 2 commits intomainfrom
NO_ISSUE/markdown-parse-error
Feb 16, 2026
Merged

fix: prevent markdown rendering error by ensuring string input#1612
Blastoplex merged 2 commits intomainfrom
NO_ISSUE/markdown-parse-error

Conversation

@Blastoplex
Copy link
Contributor

@Blastoplex Blastoplex commented Feb 16, 2026

Guard against null or undefined markdown input by defaulting to empty string before rendering. This fixes the "Input data should be a String" error caused when markdown content is missing or null in DialogMessageItem, MarkedDown component, and ToolReturnParsedItem components.

image

https://atlassian.slack.com/archives/C09DA8EUW9F/p1770768423830179

devloped in RDiJ and tested with npm run test:react

Guard against null or undefined markdown input by defaulting to empty string before rendering. This fixes the "Input data should be a String" error caused when markdown content is missing or null in DialogMessageItem, MarkedDown component, and ToolReturnParsedItem components.
@mattcolman
Copy link
Collaborator

How did you arrive at this fix? Did you prove that one of these was null or undefined in the problem cases?
Can we be test driven here and write tests for the cases we saw?

@Blastoplex
Copy link
Contributor Author

yep validating atm. per the types, its expected that the message content could be null/undefined

Will pop in some tests also

@Blastoplex
Copy link
Contributor Author

Blastoplex commented Feb 16, 2026

Updated test cases and validated they failed when the fix wasnt in.

image

@Blastoplex Blastoplex enabled auto-merge (squash) February 16, 2026 06:05
@Blastoplex Blastoplex disabled auto-merge February 16, 2026 06:05
@Blastoplex Blastoplex enabled auto-merge (squash) February 16, 2026 06:09
@Blastoplex Blastoplex merged commit 8679d03 into main Feb 16, 2026
13 checks passed
@Blastoplex Blastoplex deleted the NO_ISSUE/markdown-parse-error branch February 16, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants