WIP Apply overview related patches from fork #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sn2912
requested review from
bwieger-atlassian-com,
sdzh-atlassian,
cabella-dot,
marcomura,
akalia-atlassian and
pastelsky
as code owners
sn2912
force-pushed
the
apply-overview-patch
branch
2 times, most recently
from
01c32b0 to
e7f52e1
Compare
sn2912
force-pushed
the
apply-overview-patch
branch
from
e7f52e1 to
b28701a
Compare
| @@ -1,6 +1,7 @@ | |||
| name: Build | |||
|
|
|||
| on: | |||
| workflow_dispatch: {} | |||
There was a problem hiding this comment.
Note to self: Why is this needed?
| @@ -7,10 +7,11 @@ Stay in the flow by using Atlassian for VSCode to start work on a JIRA issue, ra | |||
|
|
|||
| [**Download now**](https://marketplace.visualstudio.com/items?itemName=Atlassian.atlascode&ssr=false#overview) | |||
|
|
|||
| ## [Devsphere specific changelog](/DEVSPHERE_CHANGELOG.md) | |||
There was a problem hiding this comment.
Remove these logs: these are not useful in upstream
| @@ -98,6 +98,16 @@ | |||
| }, | |||
| "category": "Atlassian" | |||
| }, | |||
| { | |||
| "command": "atlascode.devsphere.review.initialise", | |||
| "title": "Initialise Devsphere Review Settings", | |||
There was a problem hiding this comment.
Rename to "Unset Pull Request Review mode"
| }, | ||
| { | ||
| "command": "atlascode.devsphere.custom.reset", | ||
| "title": "Reset Devsphere Custom Configuration", |
There was a problem hiding this comment.
Rename to "Set Pull Request Review mode"
| @@ -402,6 +412,14 @@ | |||
| "title": "Disable Help Explorer", | |||
| "category": "Atlassian" | |||
| }, | |||
| { | |||
| "command": "atlascode.bitbucket.pullRequestsOverview.refresh", | |||
| "title": "Refresh", | |||
There was a problem hiding this comment.
Rename to "Refresh Pull Request Overview Panel"
| private readonly _minUpdatedTs: string; | ||
|
|
||
| private _disposable: Disposable; | ||
| private _ownerSlug: string = 'atlassian'; // Hardcoded for now as per requirements |
There was a problem hiding this comment.
Anurag has created some PR where this hardcoding has been removed in favour for a setting
There was a problem hiding this comment.
Can you absorb changes from this PR?
https://github.com/atlassian/atlascode/pull/399/commits (ignore 7958e47 and 311c9ad).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This Change?
Applied patch 9, 14, 29, 52, 56
How Has This Been Tested?
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations: