WIP Apply auth patch #454
Open
WIP Apply auth patch #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sn2912
requested review from
bwieger-atlassian-com,
sdzh-atlassian,
cabella-dot,
marcomura,
akalia-atlassian and
pastelsky
as code owners
sn2912
force-pushed
the
apply-overview-patch
branch
from
e7f52e1 to
b28701a
Compare
akalia-atlassian
requested changes
Jun 12, 2025
| @@ -292,4 +305,285 @@ describe('LoginManager', () => { | |||
| ); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('extractTokenFromGitRemoteRegex', () => { | |||
| }); | ||
| }); | ||
|
|
||
| describe('getAuthTokenFromHomeGitCredentials', () => { |
| }); | ||
| }); | ||
|
|
||
| describe('authenticateWithBitbucketToken', () => { |
| @@ -853,7 +857,7 @@ | |||
| "properties": { | |||
| "atlascode.outputLevel": { | |||
| "type": "string", | |||
| "default": "silent", | |||
| "default": "debug", | |||
There was a problem hiding this comment.
Remove for upstream. This is only for devboxes.
| @@ -223,21 +223,6 @@ describe('CredentialManager', () => { | |||
| site: mockJiraSite, | |||
| }); | |||
| }); | |||
|
|
|||
| it("should not save to secret storage if auth info hasn't changed", async () => { | |||
There was a problem hiding this comment.
Why remove this test?
| /** | ||
| * Saves the auth info to both the in-memory store and the secretstorage for Bitbucket API key login | ||
| */ | ||
| public async saveAuthInfoBBToken(site: DetailedSiteInfo, info: AuthInfo, id: number): Promise<void> { |
There was a problem hiding this comment.
This function is not used anywhere in the fork. Can be safely removed.
| @@ -0,0 +1,188 @@ | |||
| import * as vscode from 'vscode'; | |||
There was a problem hiding this comment.
Does this test file not belong to a previous PR?
akalia-atlassian
requested changes
Jun 12, 2025
| @@ -228,7 +228,7 @@ export class Container { | |||
| )), | |||
| ); | |||
| this._context.subscriptions.push((this._jiraActiveIssueStatusBar = new JiraActiveIssueStatusBar(bbCtx))); | |||
|
|
|||
| Container.authenticateWithBitbucketToken(); | |||
There was a problem hiding this comment.
Introduce a new config: isdevsphere=true and only then call this function. In upstream, we don't want to trigger this flow by default.
And add a comment that this whole flow is catered towards devsphere and not general public.
| return true; | ||
| } catch (e) { | ||
| Logger.error(e, 'Error authenticating with Bitbucket token'); | ||
| vscode.window.showErrorMessage(`Error authenticating with Bitbucket token: ${e}`); |
There was a problem hiding this comment.
Remove this log: it is removed in a later patch 58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This Change?
Applied patches for auth changes from fork for PRs 1,16,27,28,34,39,48,49, 52
How Has This Been Tested?
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations: