Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
### Bug Fixes

- Removed setting options that had no practical or business logic use.
- Added loading indicator to Refresh button for Jira issue auto-refreshes
- Fixed a bug where Jira site icon is broken in create Jira issue page
- Fixed a bug with getting the error when deleting multiple instances
- Fixed a bug where we could not assign people to a Jira issue as DC users
Expand All @@ -26,7 +27,6 @@

- Fixed a bug where issues would not render due to malformed epic fields (#665)
- Fixed status button in smaller screen size
-

## What's new in 3.8.7

Expand Down
8 changes: 8 additions & 0 deletions src/webviews/components/issue/AbstractIssueEditorPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,14 @@ export abstract class AbstractIssueEditorPage<
this.setState({ isRteEnabled: e.featureFlags.rteEnabled });
break;
}
case 'loadingStart': {
this.setState({ isSomethingLoading: true, loadingField: e.loadingField });
break;
}
case 'loadingEnd': {
this.setState({ isSomethingLoading: false, loadingField: '' });
break;
}
}

return handled;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,6 @@ export default class JiraIssuePage extends AbstractIssueEditorPage<Emit, Accept,
};

handleRefresh = () => {
this.setState({ isSomethingLoading: true, loadingField: 'refresh' });
this.postMessage({ action: 'refreshIssue' });
};

Expand Down
2 changes: 2 additions & 0 deletions src/webviews/jiraIssueWebview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ export class JiraIssueWebview
return;
}
this.isRefeshing = true;
this.postMessage({ type: 'loadingStart', loadingField: 'refresh' });
try {
if (refetchMinimalIssue) {
this._issue = await fetchMinimalIssue(this._issue.key, this._issue.siteDetails);
Expand Down Expand Up @@ -179,6 +180,7 @@ export class JiraIssueWebview
this.postMessage({ type: 'error', reason: this.formatErrorReason(e) });
} finally {
this.isRefeshing = false;
this.postMessage({ type: 'loadingEnd' });
}
}

Expand Down
Loading