Skip to content

AXON-762: Migrate frontend logic to new Start Work layout #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

sspanchenko
Copy link
Collaborator

@sspanchenko sspanchenko commented Aug 6, 2025

What Is This Change?

The current task involves migrating the logic from the old Start Work page to the new layout. All functionality has been taken from the original page, with the only difference being that the new version is split into components

How to test:

  • create .env file
  • add ATLASCODE_FF_OVERRIDES=atlascode-start-work-v3=true

Result:

image 

Design vs Implementation

As I mentioned in the layout task, some details - such as colors, spacing, or font sizes - may differ slightly from the design. This is because I tried to stick to what Material UI provides out of the box and avoided heavy overrides, aiming for easier long-term maintenance. Additionally, this approach helps the page look consistent across various VS Code themes.

Some elements on the page were carried over from the previous version exactly as they were, since we don’t have updated designs for them yet. I’ve kept them unchanged for now, but if you'd like me to update their appearance, we can easily adjust them in future iterations.

These elements include:

  • The "Use existing branch" section
    image 

  • The success/error notification block

image 

image 

  • The snackbar notification

image 

I kept the ability for the user to toggle between the same four form states as on the old page:

  • Both sections open (See the first screenshot on this page.) - Allows the user to both create a branch and update the issue status.

  • Only the first section collapsed - Allows the user to skip branch creation while still updating the issue status.

image 

  • Only the second section collapsed - Allows the user to leave the issue status unchanged.

image 

  • Both sections collapsed - Allows the user to simply assign the task to themselves.

image 

To preserve the same functionality as on the old page, I added a checkbox next to the "Create Branch" header - even though it wasn't included in the design. However, if we don't want to allow users to disable the first section, I can remove the checkbox and keep the section permanently open. Just let me know.

I also removed the settings gear button and the Custom Branch Prefix menu item, as we discussed during our daily stand-ups.

Legacy Minor Bugs

Since most of the logic was carried over from the old page, some of the minor issues we previously had may still appear here. For example, during development I noticed that branch names can sometimes be duplicated in the dropdown, which could be confusing for users.

As this task was focused solely on the redesign, it’s probably more appropriate to address these existing issues in a separate ticket. My goal here was simply to migrate the existing functionality as-is.

Testing

In addition to reviewing this PR, I’d also like to kindly ask for some functional testing - especially from those who have more experience working with this page than I do. I’ve done my best to ensure nothing was missed, but as you can see, this was a large task split across three PRs. So if you notice anything that didn’t make it over, please let me know.

Demo:

https://www.loom.com/share/be041c450914456ebcb19bf1b1c02e03

Basic checks:

  • npm run lint
  • npm run test

Advanced checks:

  • If Atlassian employee & Bitbucket changes: did you test with DC in mind? See Instructions

Recommendations:

  • Update the CHANGELOG if making a user facing change

@sspanchenko sspanchenko force-pushed the AXON-762-add-logic-to-new-layout branch 2 times, most recently from e002d9d to 623ab00 Compare August 7, 2025 08:35
@sspanchenko sspanchenko self-assigned this Aug 7, 2025
@sspanchenko sspanchenko changed the title [WIP] AXON-762: Migrate frontend logic to new Start Work layout AXON-762: Migrate frontend logic to new Start Work layout Aug 7, 2025
@sspanchenko sspanchenko requested a review from bhorai-atl August 7, 2025 12:36
@sspanchenko sspanchenko marked this pull request as ready for review August 7, 2025 12:37
@sspanchenko sspanchenko force-pushed the AXON-762-add-logic-to-new-layout branch from 6a2480e to a8d9245 Compare August 8, 2025 10:00
@sspanchenko sspanchenko force-pushed the AXON-762-add-logic-to-new-layout branch from f86d3ea to 5aebbfc Compare August 8, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant