Skip to content

fix(payment-widget): types #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nelfimov merged 4 commits into from
Jan 7, 2025

feat(common): bump yarn

3007002
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix(payment-widget): types #154

feat(common): bump yarn
3007002
Select commit
Loading
Failed to load commit list.
GitHub Actions / Lint failed Jan 7, 2025 in 0s

Errors 72, Warnings 14

Found 72 errors and 14 warnings

Annotations

Check failure on line 11 in packages/api-auth-user/src/api-auth-user.provider.tsx

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/no-explicit-any): Unexpected any. Specify a different type. 

Unexpected any. Specify a different type.
Raw output 
   8 | import { UserProvider }   from '@atls/react-user'
   9 |
> 10 | type Session = any
     |                ^
  11 |
  12 | interface ApiAuthUserProviderProps {
  13 |   url?: string

Check warning on line 22 in packages/api-auth-user/src/api-auth-user.provider.tsx

See this annotation in the file changed.

@github-actions github-actions / Lint

(unknown): Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-unsafe-return'). 

Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-unsafe-return').
Raw output 
  19 |   const text = await response.text()
  20 |
> 21 |   // eslint-disable-next-line @typescript-eslint/no-unsafe-return
     |   ^
  22 |   return text ? JSON.parse(text) : null
  23 | }
  24 |

Check failure on line 8 in packages/app-links/src/app-url.interfaces.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/no-deprecated): `JSX` is deprecated. Use `React.JSX` instead of the global `JSX` namespace. 

`JSX` is deprecated. Use `React.JSX` instead of the global `JSX` namespace.
Raw output 
  5 |
  6 | export interface AppLinkProps extends UseAppUrlProps {
> 7 |   children?: (value: string) => JSX.Element
    |                                 ^
  8 | }
  9 |

Check failure on line 3 in packages/app-links/src/index.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/consistent-type-exports): All exports in the declaration are only used as types. Use `export type`. 

All exports in the declaration are only used as types. Use `export type`.
Raw output 
  1 | export * from './app-link.component'
> 2 | export * from './app-url.interfaces'
    | ^
  3 | export * from './use-app-url.hook'
  4 |

Check failure on line 17 in packages/app-links/src/use-app-url.hook.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/no-non-null-assertion): Forbidden non-null assertion. 

Forbidden non-null assertion.
Raw output 
  14 |     const domain = getDomain(hostname)
  15 |
> 16 |     const origin = subdomain ? `${protocol}//${subdomain}.${domain!}` : `${protocol}//${domain!}`
     |                                                             ^
  17 |
  18 |     setUrl(`${origin}${pathname}`)
  19 |   }, [subdomain, pathname])

Check failure on line 17 in packages/app-links/src/use-app-url.hook.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/no-non-null-assertion): Forbidden non-null assertion. 

Forbidden non-null assertion.
Raw output 
  14 |     const domain = getDomain(hostname)
  15 |
> 16 |     const origin = subdomain ? `${protocol}//${subdomain}.${domain!}` : `${protocol}//${domain!}`
     |                                                                                         ^
  17 |
  18 |     setUrl(`${origin}${pathname}`)
  19 |   }, [subdomain, pathname])

Check warning on line 2 in packages/app-links/src/use-browser-effect.hook.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(unknown): Unused eslint-disable directive (no problems were reported from 'react-hooks/exhaustive-deps'). 

Unused eslint-disable directive (no problems were reported from 'react-hooks/exhaustive-deps').
Raw output 
> 1 | /* eslint-disable react-hooks/exhaustive-deps */
    | ^
  2 | /* eslint-disable react-hooks/rules-of-hooks */
  3 |
  4 | import type { EffectCallback } from 'react'

Check failure on line 17 in packages/identity-links/src/identity-link.component.test.tsx

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/ban-ts-comment): Include a description after the "@ts-expect-error" directive to explain why the @ts-expect-error is necessary. The description must be 10 characters or longer. 

Include a description after the "@ts-expect-error" directive to explain why the @ts-expect-error is necessary. The description must be 10 characters or longer.
Raw output 
  14 |
  15 |   const mockWindowLocation = (newLocation: Location | URL | string): void => {
> 16 |     // @ts-expect-error
     |     ^
  17 |     delete window.location
  18 |     // @ts-expect-error
  19 |     window.location = newLocation

Check failure on line 19 in packages/identity-links/src/identity-link.component.test.tsx

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/ban-ts-comment): Include a description after the "@ts-expect-error" directive to explain why the @ts-expect-error is necessary. The description must be 10 characters or longer. 

Include a description after the "@ts-expect-error" directive to explain why the @ts-expect-error is necessary. The description must be 10 characters or longer.
Raw output 
  16 |     // @ts-expect-error
  17 |     delete window.location
> 18 |     // @ts-expect-error
     |     ^
  19 |     window.location = newLocation
  20 |   }
  21 |

Check warning on line 31 in packages/identity-links/src/identity-link.component.test.tsx

See this annotation in the file changed.

@github-actions github-actions / Lint

(unknown): Unused eslint-disable directive (no problems were reported from '@typescript-eslint/explicit-function-return-type'). 

Unused eslint-disable directive (no problems were reported from '@typescript-eslint/explicit-function-return-type').
Raw output 
  28 |
  29 |     const { getByText } = render(
> 30 |       // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
     |       ^
  31 |       <IdentityLink returnTo>{(url) => <a href={url}>Login</a>}</IdentityLink>
  32 |     )
  33 |

Check failure on line 21 in packages/identity-links/src/identity-url.interfaces.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/no-deprecated): `JSX` is deprecated. Use `React.JSX` instead of the global `JSX` namespace. 

`JSX` is deprecated. Use `React.JSX` instead of the global `JSX` namespace.
Raw output 
  18 |
  19 | export interface IdentityLinkProps extends UseIdentityUrlProps {
> 20 |   children?: (value: string) => JSX.Element
     |                                 ^
  21 | }
  22 |

Check failure on line 3 in packages/identity-links/src/index.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/consistent-type-exports): All exports in the declaration are only used as types. Use `export type`. 

All exports in the declaration are only used as types. Use `export type`.
Raw output 
  1 | export * from './identity-link.component'
> 2 | export * from './identity-url.interfaces'
    | ^
  3 | export * from './use-identity-url.hook'
  4 |

Check warning on line 2 in packages/identity-links/src/use-browser-effect.hook.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(unknown): Unused eslint-disable directive (no problems were reported from 'react-hooks/exhaustive-deps'). 

Unused eslint-disable directive (no problems were reported from 'react-hooks/exhaustive-deps').
Raw output 
> 1 | /* eslint-disable react-hooks/exhaustive-deps */
    | ^
  2 | /* eslint-disable react-hooks/rules-of-hooks */
  3 |
  4 | import type { EffectCallback } from 'react'

Check failure on line 14 in packages/identity-links/src/use-identity-url.hook.test.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/ban-ts-comment): Include a description after the "@ts-expect-error" directive to explain why the @ts-expect-error is necessary. The description must be 10 characters or longer. 

Include a description after the "@ts-expect-error" directive to explain why the @ts-expect-error is necessary. The description must be 10 characters or longer.
Raw output 
  11 |
  12 |   const mockWindowLocation = (newLocation: Location | URL | string): void => {
> 13 |     // @ts-expect-error
     |     ^
  14 |     delete window.location
  15 |     // @ts-expect-error
  16 |     window.location = newLocation

Check failure on line 16 in packages/identity-links/src/use-identity-url.hook.test.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/ban-ts-comment): Include a description after the "@ts-expect-error" directive to explain why the @ts-expect-error is necessary. The description must be 10 characters or longer. 

Include a description after the "@ts-expect-error" directive to explain why the @ts-expect-error is necessary. The description must be 10 characters or longer.
Raw output 
  13 |     // @ts-expect-error
  14 |     delete window.location
> 15 |     // @ts-expect-error
     |     ^
  16 |     window.location = newLocation
  17 |   }
  18 |

Check warning on line 33 in packages/identity-links/src/use-identity-url.hook.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(unknown): Unused eslint-disable directive (no problems were reported from '@typescript-eslint/restrict-template-expressions'). 

Unused eslint-disable directive (no problems were reported from '@typescript-eslint/restrict-template-expressions').
Raw output 
  30 |
  31 |       if (returnTo === false) {
> 32 |         // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
     |         ^
  33 |         setUrl(`${protocol}//accounts.${domain}${path}`)
  34 |       } else if (returnTo === true) {
  35 |         // eslint-disable-next-line @typescript-eslint/restrict-template-expressions

Check warning on line 36 in packages/identity-links/src/use-identity-url.hook.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(unknown): Unused eslint-disable directive (no problems were reported from '@typescript-eslint/restrict-template-expressions'). 

Unused eslint-disable directive (no problems were reported from '@typescript-eslint/restrict-template-expressions').
Raw output 
  33 |         setUrl(`${protocol}//accounts.${domain}${path}`)
  34 |       } else if (returnTo === true) {
> 35 |         // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
     |         ^
  36 |         setUrl(`${protocol}//accounts.${domain}${path}?return_to=${href}`)
  37 |       } else {
  38 |         const returnToOrigin = returnTo.subdomain

Check warning on line 40 in packages/identity-links/src/use-identity-url.hook.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(unknown): Unused eslint-disable directive (no problems were reported from '@typescript-eslint/restrict-template-expressions'). 

Unused eslint-disable directive (no problems were reported from '@typescript-eslint/restrict-template-expressions').
Raw output 
  37 |       } else {
  38 |         const returnToOrigin = returnTo.subdomain
> 39 |           ? // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
     |             ^
  40 |             `${protocol}//${returnTo.subdomain}.${domain}`
  41 |           : origin
  42 |         const returnToValue = `${returnToOrigin}${returnTo.pathname ? returnTo.pathname : pathname}`

Check warning on line 45 in packages/identity-links/src/use-identity-url.hook.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(unknown): Unused eslint-disable directive (no problems were reported from '@typescript-eslint/restrict-template-expressions'). 

Unused eslint-disable directive (no problems were reported from '@typescript-eslint/restrict-template-expressions').
Raw output 
  42 |         const returnToValue = `${returnToOrigin}${returnTo.pathname ? returnTo.pathname : pathname}`
  43 |
> 44 |         // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
     |         ^
  45 |         setUrl(`${protocol}//accounts.${domain}${path}?return_to=${returnToValue}`)
  46 |       }
  47 |     }

Check failure on line 16 in packages/identity-user-provider/src/identity-browser.user-provider.tsx

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/no-explicit-any): Unexpected any. Specify a different type. 

Unexpected any. Specify a different type.
Raw output 
  13 | export type BasePath = BasePathFn | string
  14 |
> 15 | export type Session = Record<string, any>
     |                                      ^
  16 |
  17 | export type IdentityBrowserUserProviderProps = {
  18 |   basePath?: BasePath

Check failure on line 32 in packages/identity-user-provider/src/identity-browser.user-provider.tsx

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/no-non-null-assertion): Forbidden non-null assertion. 

Forbidden non-null assertion.
Raw output 
  29 |   const domain = getDomain(hostname)
  30 |
> 31 |   return `${protocol}//identity.${domain!}`
     |                                   ^
  32 | }
  33 |
  34 | export class IdentitySessionsWhoamiUrl {

Check failure on line 70 in packages/identity-user-provider/src/identity-browser.user-provider.tsx

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/ban-ts-comment): Include a description after the "@ts-expect-error" directive to explain why the @ts-expect-error is necessary. The description must be 10 characters or longer. 

Include a description after the "@ts-expect-error" directive to explain why the @ts-expect-error is necessary. The description must be 10 characters or longer.
Raw output 
  67 |
  68 |   useBrowserEffect(() => {
> 69 |     // @ts-expect-error
     |     ^
  70 |     fetchSession(IdentitySessionsWhoamiUrl.fromBasePath(basePath)).then(setSession)
  71 |   }, [locationExtractedBasePath])
  72 |

Check warning on line 2 in packages/identity-user-provider/src/use-browser-effect.hook.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(unknown): Unused eslint-disable directive (no problems were reported from 'react-hooks/exhaustive-deps'). 

Unused eslint-disable directive (no problems were reported from 'react-hooks/exhaustive-deps').
Raw output 
> 1 | /* eslint-disable react-hooks/exhaustive-deps */
    | ^
  2 | /* eslint-disable react-hooks/rules-of-hooks */
  3 |
  4 | import type { EffectCallback } from 'react'

Check failure on line 7 in packages/upload/src/use-gateway-url.hook.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/no-non-null-assertion): Forbidden non-null assertion. 

Forbidden non-null assertion.
Raw output 
  4 |   const url = useAppUrl({ subdomain: 'gateway' })
  5 |
> 6 |   return defaultUrl || url!
    |                        ^
  7 | }
  8 |

Check failure on line 6 in packages/user/src/use-user.hook.ts

See this annotation in the file changed.

@github-actions github-actions / Lint

(@typescript-eslint/no-explicit-any): Unexpected any. Specify a different type. 

Unexpected any. Specify a different type.
Raw output 
  3 | import { Context }    from './user.context'
  4 |
> 5 | export const useUser = (): any => useContext(Context)
    |                            ^
  6 |
View more details on GitHub Actions