Skip to content

Feat/init#1

Open
comfrt1k wants to merge 35 commits intomasterfrom
feat/init
Open

Feat/init#1
comfrt1k wants to merge 35 commits intomasterfrom
feat/init

Conversation

@comfrt1k
Copy link

Таска:

Пруфы:

Details image

@comfrt1k comfrt1k self-assigned this Jan 22, 2026
@comfrt1k comfrt1k requested a review from Amiditin January 22, 2026 23:43
@comfrt1k comfrt1k requested a review from Amiditin March 3, 2026 00:55
Amiditin

This comment was marked as outdated.

Copy link
Member

@Amiditin Amiditin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поправь конфликты и запусти чеки

@comfrt1k comfrt1k requested a review from Amiditin March 3, 2026 23:30
@Amiditin Amiditin requested a review from TorinAsakura March 3, 2026 23:35
Copy link
Member

@TorinAsakura TorinAsakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Проблема: в build-скрипте frontend/app/entrypoint/package.json после next build используется ;.

Почему это важно: шаги копирования запускаются даже если сборка упала, из-за чего можно пропустить реальный фейл (особенно если остались старые артефакты .next).

Предложение: заменить ; на &&, чтобы скрипт падал сразу при ошибке:
next build && cp -r ./.next/standalone/frontend/app/entrypoint ./dist && cp -r ./.next/static ./dist/.next/static && rm -f ./dist/package.json

Путь .next/standalone/frontend/app/entrypoint валидный, это замечание только про обработку ошибок в пайплайне сборки.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants