Faster autocomplete list showing #257
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Zadeh supports adding all the files to its cache using
ArrayFiltererinstead of callingfilterevery time. If we useArrayFilterersearching will be fasterhttps://github.com/atom-community/zadeh#arrayfilterer
I'm also inclined to add the things like
prefix(which is used asrelativeToPathhere) orextentionfiltering to Zadeh.Benchmarks to test:
Repo DefinitelyTyped
Calling
filterdirectly each time takes 25ms (typeimport "something")autocomplete-paths/lib/paths-provider.js
Line 138 in 1d6979f
Filtering extensions takes 7.5ms (type
import "something")autocomplete-paths/lib/paths-provider.js
Lines 132 to 135 in 1d6979f
Filtering relativeToPath takes 7.7ms (type
import "./")autocomplete-paths/lib/paths-cache.js
Line 64 in 1d6979f
Other benchmarks:
Top to bottom

Bottom to top