fix: use Map for decorationDestroyedSubscriptions

Author: aminya

lib/mixins/decoration-management.js

@@ -65,7 +65,7 @@ export default class DecorationManagement {
      * @type {Object}
      * @access private
      */
-    this.decorationDestroyedSubscriptions = {}
+    this.decorationDestroyedSubscriptions = new Map()
   }
 
   /**
@@ -409,10 +409,10 @@ export default class DecorationManagement {
       }))
     }
 
-    this.decorationDestroyedSubscriptions[decoration.id] =
+    this.decorationDestroyedSubscriptions.set(decoration.id,
     decoration.onDidDestroy(() => {
       this.removeDecoration(decoration)
-    })
+    }))
 
     this.emitDecorationChanges(type, decoration)
     this.emitter.emit('did-add-decoration', {
@@ -529,11 +529,11 @@ export default class DecorationManagement {
     subscription = this.decorationUpdatedSubscriptions.get(decoration.id)
     if (subscription != null) { subscription.dispose() }
 
-    subscription = this.decorationDestroyedSubscriptions[decoration.id]
+    subscription = this.decorationDestroyedSubscriptions.get(decoration.id)
     if (subscription != null) { subscription.dispose() }
 
     this.decorationUpdatedSubscriptions.delete(decoration.id)
-    delete this.decorationDestroyedSubscriptions[decoration.id]
+    this.decorationDestroyedSubscriptions.delete(decoration.id)
 
     const decorations = this.decorationsByMarkerId.get(marker.id)
     if (!decorations) { return }
@@ -619,8 +619,9 @@ export default class DecorationManagement {
       decoration.dispose()
     }
 
-    for (const id in this.decorationDestroyedSubscriptions) {
-      this.decorationDestroyedSubscriptions[id].dispose()
+    const decorationDestroyedSubscriptionsValues = this.decorationDestroyedSubscriptions.values()
+    for (const decoration of decorationDestroyedSubscriptionsValues) {
+      decoration.dispose()
     }
 
     const decorationsByIdValues = this.decorationsById.values()
@@ -633,6 +634,6 @@ export default class DecorationManagement {
     this.decorationMarkerChangedSubscriptions.clear()
     this.decorationMarkerDestroyedSubscriptions.clear()
     this.decorationUpdatedSubscriptions.clear()
-    this.decorationDestroyedSubscriptions = {}
+    this.decorationDestroyedSubscriptions.clear()
   }
 }