✅ remaining tests :fingers_crossed:

Author: smashwilson

test/views/dialog-view.test.js

@@ -88,38 +88,7 @@ describe('DialogView', function() {
       const button = wrapper.find('.btn-primary');
       assert.isTrue(button.hasClass('icon'));
       assert.isTrue(button.hasClass('icon-repo-clone'));
-      assert.strictEqual(button.text(), 'Engage');
-    });
-  });
-
-  describe('tabbing', function() {
-    let div;
-
-    beforeEach(function() {
-      div = document.createElement('div');
-      div.tabIndex = 1000000;
-      document.body.appendChild(div);
-    });
-
-    afterEach(function() {
-      div.remove();
-    });
-
-    it('assigns successive distinct tab indices to button elements', function() {
-      const tabGroup = new TabGroup();
-      const wrapper = shallow(buildApp({tabGroup}));
-
-      assert.strictEqual(wrapper.find('.github-Dialog-cancelButton').prop('tabIndex'), 1000001);
-      assert.strictEqual(wrapper.find('.btn-primary').prop('tabIndex'), 1000002);
-    });
-
-    it('recaptures focus after it leaves the dialog element', function() {
-      const tabGroup = new TabGroup();
-      const wrapper = shallow(buildApp({tabGroup}));
-
-      sinon.spy(tabGroup, 'focusBeginning');
-      wrapper.find('.github-Dialog').prop('onTransitionEnd')();
-      assert.isTrue(tabGroup.focusBeginning.called);
+      assert.strictEqual(button.prop('children'), 'Engage');
     });
   });
 

test/views/directory-select.test.js

@@ -4,6 +4,7 @@ import {TextBuffer} from 'atom';
 
 import DirectorySelect from '../../lib/views/directory-select';
 import TabGroup from '../../lib/tab-group';
+import {TabbableTextEditor} from '../../lib/views/tabbable';
 
 describe('DirectorySelect', function() {
   let atomEnv;
@@ -34,13 +35,13 @@ describe('DirectorySelect', function() {
     const buffer = new TextBuffer();
     const wrapper = shallow(buildApp({buffer}));
 
-    assert.strictEqual(wrapper.find('AtomTextEditor.github-DirectorySelect-destinationPath').prop('buffer'), buffer);
+    assert.strictEqual(wrapper.find('.github-DirectorySelect-destinationPath').prop('buffer'), buffer);
   });
 
   it('disables both controls', function() {
     const wrapper = shallow(buildApp({disabled: true}));
 
-    assert.isTrue(wrapper.find('AtomTextEditor').prop('readOnly'));
+    assert.isTrue(wrapper.find(TabbableTextEditor).prop('readOnly'));
     assert.isTrue(wrapper.find('.btn.icon-file-directory').prop('disabled'));
   });
 

test/views/open-commit-dialog.test.js

@@ -5,6 +5,7 @@ import OpenCommitDialog, {openCommitDetailItem} from '../../lib/views/open-commi
 import {dialogRequests} from '../../lib/controllers/dialogs-controller';
 import CommitDetailItem from '../../lib/items/commit-detail-item';
 import {GitError} from '../../lib/git-shell-out-strategy';
+import {TabbableTextEditor} from '../../lib/views/tabbable';
 import * as reporterProxy from '../../lib/reporter-proxy';
 
 describe('OpenCommitDialog', function() {
@@ -19,7 +20,7 @@ describe('OpenCommitDialog', function() {
   });
 
   function isValidRef(ref) {
-    return Promise.resolve(ref === 'abcd1234');
+    return Promise.resolve(/^abcd/.test(ref));
   }
 
   function buildApp(overrides = {}) {
@@ -46,9 +47,12 @@ describe('OpenCommitDialog', function() {
 
     it('enables the open button when commit sha box is populated', function() {
       const wrapper = shallow(buildApp());
-      wrapper.find('AtomTextEditor').prop('buffer').setText('abcd1234');
+      wrapper.find(TabbableTextEditor).prop('buffer').setText('abcd1234');
 
       assert.isTrue(wrapper.find('DialogView').prop('acceptEnabled'));
+
+      wrapper.find(TabbableTextEditor).prop('buffer').setText('abcd6789');
+      assert.isTrue(wrapper.find('DialogView').prop('acceptEnabled'));
     });
   });
 
@@ -58,13 +62,24 @@ describe('OpenCommitDialog', function() {
     request.onAccept(accept);
 
     const wrapper = shallow(buildApp({request}));
-    wrapper.find('AtomTextEditor').prop('buffer').setText('abcd1234');
+    wrapper.find(TabbableTextEditor).prop('buffer').setText('abcd1234');
     wrapper.find('DialogView').prop('accept')();
 
     assert.isTrue(accept.calledWith('abcd1234'));
     wrapper.unmount();
   });
 
+  it('does nothing on accept if the ref is empty', async function() {
+    const accept = sinon.spy();
+    const request = dialogRequests.commit();
+    request.onAccept(accept);
+
+    const wrapper = shallow(buildApp({request}));
+    await wrapper.find('DialogView').prop('accept')();
+
+    assert.isFalse(accept.called);
+  });
+
   it('calls the cancellation callback', function() {
     const cancel = sinon.spy();
     const request = dialogRequests.commit();