Skip to content

Conversation

@petermm
Copy link
Contributor

@petermm petermm commented Nov 13, 2025

Otherwise changes to elixir tests are not picked up, and CI results are untrustworthy.

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@bettio
Copy link
Collaborator

bettio commented Nov 15, 2025

Schermata_20251115_113715 There is an unusual number of failed checks, can you check if everything is working as expected?

@petermm petermm force-pushed the fix-ci-cache-key-ex-files branch from 8f6ae1f to dc27f68 Compare November 15, 2025 11:19
@petermm petermm changed the title CI: Include .ex files in cache key CI: Exclude elixir test files from cache Nov 15, 2025
@pguyot
Copy link
Collaborator

pguyot commented Nov 15, 2025

Schermata_20251115_113715

There is an unusual number of failed checks, can you check if everything is working as expected?

Ahhh. I thought it was in my branch.

It's a bug in inclusion of jit modules I believe, combined with caching. I'm hunting this one.

Otherwise changes to elixir tests are not picked up.

Signed-off-by: Peter M <[email protected]>
@petermm petermm force-pushed the fix-ci-cache-key-ex-files branch from dc27f68 to d119dc0 Compare November 15, 2025 16:56
@petermm petermm changed the title CI: Exclude elixir test files from cache CI: Include .ex (and .hrl) files in cache key Nov 15, 2025
@petermm
Copy link
Contributor Author

petermm commented Nov 15, 2025

Ok, fyi I've added .hrl files as well to cache key - seems correct?

@pguyot
Copy link
Collaborator

pguyot commented Nov 16, 2025

Ok, fyi I've added .hrl files as well to cache key - seems correct?

We also need #1981 I believe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants