JIT: Fix missing untag of BSBinaryReg in do_get_tail#2177
Closed
pguyot wants to merge 1 commit intoatomvm:mainfrom
Closed
JIT: Fix missing untag of BSBinaryReg in do_get_tail#2177pguyot wants to merge 1 commit intoatomvm:mainfrom
pguyot wants to merge 1 commit intoatomvm:mainfrom
Conversation
BSBinaryReg holds a tagged binary term (from match state element 1). In do_get_tail, it was used directly as a base pointer in get_array_element, causing ldr to use an address offset by the tag bits (TERM_PRIMARY_BOXED = 0x02). Signed-off-by: Paul Guyot <pguyot@kallisys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BSBinaryReg holds a tagged binary term (from match state element 1). In do_get_tail, it was used directly as a base pointer in get_array_element, causing ldr to use an address offset by the tag bits (TERM_PRIMARY_BOXED = 0x02).
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later