Updates the ICM peripheral to use the clock::v2 API
#927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Appreciate the documentation updates as well. |
ianrrees
reviewed
Jul 20, 2025
hal/src/peripherals/icm.rs
Outdated
| @@ -877,23 +910,19 @@ impl<I: RegionNum> Region<I> { | |||
| pub struct Icm { | |||
| /// ICM pac register providing hardware access | |||
| icm: crate::pac::Icm, | |||
| _ahb_clk: IcmAhbClk, | |||
There was a problem hiding this comment.
Let's remove the leading underscore from these, they do get used in free().
hal/src/peripherals/icm.rs
Outdated
| pub fn new(icm: crate::pac::Icm, ahb_clk: IcmAhbClk, apb_clk: IcmApbClk) -> Self { | ||
| Self { | ||
| icm, | ||
| _ahb_clk: ahb_clk, |
There was a problem hiding this comment.
With the underscore removed as above, clippy will want this to look like ahb_clk, r/t ahb_clk: ahb_clk,
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Jul 21, 2025
…in the `Icm` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Jul 21, 2025
…in the `Dsu` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Jul 21, 2025
…in the `Dsu` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Jul 30, 2025
…in the `Dsu` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Aug 4, 2025
…in the `Icm` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Aug 13, 2025
…in the `Dsu` struct per the recommendation in PR atsamd-rs#927.
* `Icm::new` now requires ownership of its `AhbClk` and `ApbClk`.
* Renames `Icm::destroy` to the standard `Icm::free` method to free the `pac::Icm` and bus clocks.
* Updates the `icm` module documentation example to include the above changes.
…in the `Icm` struct per the recommendation in PR atsamd-rs#927.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of the
clock::v2effort tracked in Issue #912, this PR updates theicmto use theclock::v2API by requiring ownership of itsAhbClkandApbClk. Note that this peripheral is only onthumbv7targets.No examples on any Tier 1 BSPs use the ICM so none were affected.
Checklist
#[allow]certain lints where reasonable, but ideally justify those with a short comment.