Skip to content
This repository was archived by the owner on Jun 25, 2025. It is now read-only.

Unref the interval to allow server to exit #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Unref the interval to allow server to exit #12

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84b18a0
Unref the interval to allow server to exit
bttger Oct 10, 2022
69bb712
Fix old variable name
bttger Oct 10, 2022
f540643
Write tests for unreferencing the expiration interval
bttger Oct 12, 2022
18b3081
Update test/index_test.js
TimDaub Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ module.exports = ({ Store }) => {
intervalMs:
(options.expired && options.expired.intervalMs) ||
clearExpiredInterval,
unrefInterval: (options.expired && options.expired.unrefInterval) ||
Copy link
Member

@TimDaub TimDaub Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'd have to add any new option property to the documentation. And why do we need "|| false" ?

Copy link
Contributor Author

@bttger bttger Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will add it to the docs if you accept it to be added. Regarding the "false", that's redundant of course and I'll remove it.

false,
};
this.client = options.client;
this.createDb();
Expand All @@ -40,10 +42,13 @@ module.exports = ({ Store }) => {
}

startInterval() {
setInterval(
const timeout = setInterval(
this.clearExpiredSessions.bind(this),
this.expired.intervalMs
);
if (this.expired.unrefInterval) {
timeout.unref();
}
}

clearExpiredSessions() {
Expand Down