fix: preserve empty lines in multi-line strings#32
Merged
attilarepka merged 1 commit intoattilarepka:masterfrom Nov 25, 2025
Merged
fix: preserve empty lines in multi-line strings#32attilarepka merged 1 commit intoattilarepka:masterfrom
attilarepka merged 1 commit intoattilarepka:masterfrom
Conversation
Previously, `string_to_table` used `gmatch("[^\r\n]+")` which caused
empty lines in multi-line strings (e.g., license text paragraphs) to be
swallowed. This resulted in headers being compressed without proper
paragraph separation.
This commit:
- Replaces `gmatch` with `vim.split` to correctly preserve empty lines.
- Handles CRLF normalization.
- Removes the trailing empty line that typically occurs with Lua
multi-line strings.
- Updates `license_spec.lua` to expect correct paragraph spacing in
generated headers.
Contributor
Author
|
fix issue #29 |
attilarepka
approved these changes
Nov 25, 2025
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
string_to_tableusedgmatch("[^\r\n]+")which caused empty lines in multi-line strings (e.g., license text paragraphs) to be swallowed. This resulted in headers being compressed without proper paragraph separation.This commit:
gmatchwithvim.splitto correctly preserve empty lines.license_spec.luato expect correct paragraph spacing in generated headers.