Skip to content

feat: update script for smoother setup#3230

Merged
ellie merged 2 commits intomainfrom
ellie/onboarding
Mar 3, 2026
Merged

feat: update script for smoother setup#3230
ellie merged 2 commits intomainfrom
ellie/onboarding

Conversation

@ellie
Copy link
Member

@ellie ellie commented Mar 3, 2026

Many users do not seem to read the docs. So, make the install script handle most of the things that we include in the docs quickstart.

Ensures that the install script still functions as expected in non-interactive environments - setup scripts, ci, etc. Offers a flag just in case this check fails, to force non-interactive setup.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Many users do not seem to read the docs. So, make the install script
handle most of the things that we include in the docs quickstart.

Ensures that the install script still functions as expected in
non-interactive environments - setup scripts, ci, etc. Offers a flag
just in case this check fails, to force non-interactive setup.
@ellie ellie requested a review from BinaryMuse March 3, 2026 15:38
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 3, 2026

Greptile Summary

This PR upgrades the install script to guide users through history import and sync account setup after installation, with automatic TTY detection and a --non-interactive flag for CI/headless environments.

The bash-preexec curl call properly uses TLS/security flags (--proto '=https' --tlsv1.2 -LsSf), and the [ -t 0 ] || [ -c /dev/tty ] check for TTY detection is reasonable. However, atuin register should redirect from /dev/tty to match the pattern used by other interactive prompts in the script, preventing potential stdin-at-EOF failures in curl | sh pipelines.

Last reviewed commit: 1770536

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

BinaryMuse
BinaryMuse previously approved these changes Mar 3, 2026
Copy link
Member

@BinaryMuse BinaryMuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall flow looks good to me; don't know about the stdin stuff greptile raised (I'm probably the worst person to review this 😅)

@ellie
Copy link
Member Author

ellie commented Mar 3, 2026

yeah I think greptile is correct, will double check and try it on a few fresh machines! ty

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@ellie ellie merged commit 10ea7c3 into main Mar 3, 2026
36 checks passed
@ellie ellie deleted the ellie/onboarding branch March 3, 2026 16:10
pull bot pushed a commit to hareki/atuin that referenced this pull request Mar 3, 2026
Many users do not seem to read the docs. So, make the install script
handle most of the things that we include in the docs quickstart.

Ensures that the install script still functions as expected in
non-interactive environments - setup scripts, ci, etc. Offers a flag
just in case this check fails, to force non-interactive setup.

<!-- Thank you for making a PR! Bug fixes are always welcome, but if
you're adding a new feature or changing an existing one, we'd really
appreciate if you open an issue, post on the forum, or drop in on
Discord -->

## Checks
- [ ] I am happy for maintainers to push small adjustments to this PR,
to speed up the review cycle
- [ ] I have checked that there are no existing pull requests for the
same thing

---------

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants