A collection of updates and build time flag adjustments#3248
Merged
Conversation
Contributor
Greptile SummaryThis PR reduces binary size and trims unnecessary dependencies by upgrading axum (0.7→0.8), thiserror (1→2), stripping symbols in the dist profile, and narrowing minijinja's enabled features. The axum upgrade is handled correctly —
Important Files Changed
Last reviewed commit: aac93ef |
Adds strip = "symbols" to the cargo dist profile, removing debug symbols and symbol tables from the release binary (~5MiB savings).
Our crates used thiserror 1.x while the ratatui ecosystem already pulled in thiserror 2.x, resulting in both versions in the binary. The API is compatible; this consolidates to a single version.
atuin-server used axum 0.7 while tonic already pulled in axum 0.8,
resulting in both versions compiled into the binary. Migrates to
axum 0.8: path params use {param} syntax, FromRequestParts uses
native async traits (dropping async-trait dep from atuin-server).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here is to reduce the final binary size, and also reduce dependencies that we don't actually need to have included
Checks