Skip to content

fix: support mysql-compatible databases that only support constant values in set statements#358

Merged
ellie merged 2 commits intomainfrom
ellie/fix-issue-357
Jan 21, 2026
Merged

fix: support mysql-compatible databases that only support constant values in set statements#358
ellie merged 2 commits intomainfrom
ellie/fix-issue-357

Conversation

@ellie
Copy link
Member

@ellie ellie commented Jan 21, 2026

Resolves #357

Tasks

  • Regenerated TS-RS bindings (if any ts(export) structs have changed)
  • Updated the documentation in docs/ (if any application behavior has changed)
  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 21, 2026

Greptile Summary

Added opt-in support for MySQL-compatible databases (StarRocks, Doris) that don't support dynamic SET statements. Users can now enable "Skip SQL mode initialization" in MySQL block settings to disable pipes_as_concat and no_engine_substitution sqlx options.

  • Backend adds skip_sql_mode_init boolean flag to MySQL block configuration
  • Frontend adds settings modal with toggle switch for the new option
  • Changes properly propagated through TypeScript models and React components
  • Maintains backwards compatibility with default value of false

Important Files Changed

Filename Overview
crates/atuin-desktop-runtime/src/blocks/mysql.rs Added skipSqlModeInit flag to disable dynamic SET statements for StarRocks/Doris compatibility
src/components/runbooks/editor/blocks/MySQL/MySQL.tsx Added UI toggle for skipSqlModeInit with settings modal
src/lib/blocks/common/SQL.tsx Added generic settings modal infrastructure for SQL blocks
src/lib/workflow/blocks/mysql.ts Added skipSqlModeInit property to MySqlBlock model with proper serialization

@ellie ellie enabled auto-merge (rebase) January 21, 2026 02:08
@ellie ellie disabled auto-merge January 21, 2026 02:08
@ellie ellie merged commit 75a1f68 into main Jan 21, 2026
8 checks passed
@ellie ellie deleted the ellie/fix-issue-357 branch January 21, 2026 02:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Support Starrocks ?

1 participant