Add icons for 'No Playlist Advance'#1618
Closed
sunhaitao wants to merge 2 commits intoaudacious-media-player:masterfrom
Closed
Add icons for 'No Playlist Advance'#1618sunhaitao wants to merge 2 commits intoaudacious-media-player:masterfrom
sunhaitao wants to merge 2 commits intoaudacious-media-player:masterfrom
Conversation
Member
|
Maybe consider an icon using the digit "1" (i.e. one track)? The two horizontal bars / equal sign icon doesn't really seem to indicate "no playlist advance". |
Member
|
Alternatively: just use a text label "1" on the toolbar button. No need to add new icons at all then. |
Member
|
See audacious-media-player/audacious-plugins#187 for an alternative |
Member
|
As discussed in Pull Request 187 we will not merge this, at least for now. Thanks anyway @sunhaitao for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the current solution to repeat a single track involves setting 'No Playlist Advance', a toggle button in GUIs would be handy to indicate the current state. This pull request adds icons for such buttons in both the Qt and GTK UIs.