Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I wanna hotfix demuxer error handling.
What happened: library called 'audio-decode' use package 'av', that uses this package for decoding mp3-files to buffer.
Usage of 'av' in 'audio-decode': https://github.com/audiojs/audio-decode/blob/master/index.js#L80=
As you can see, error handling looks good. Buuut, in runtime in some cases thrown error terminate node process (screenshot):
I try to handle this by try-catch block inside my project, but this dont work (idk why):
So, when I added try-catch block inside 'mp3' package (as at this PR) problem got fixed. So, handled error message look like this:
