Conversation
…version less than 8 because it was removed.
… show a confirmation code on the final page and to generate a random subject ID for each session
…ouped.yaml more different than the pref.yaml
|
@nullpunktTUD this is awesome. Thanks! I won't have time to review this before end of June. There are some javascript linter that could detect some errors maybe run this before... |
faroit
left a comment
faroit
left a comment
There was a problem hiding this comment.
As I said, I won't be able to provide a full review but this looks already quite good to me.
@nullpunktTUD is there things missing? Otherwise I would give this a test and if things work as advertised, we can merge this.
Please also see my minor comments
| this.filePlayer.genericAudioControl.addEventListener((function (_event) { | ||
| if (_event.name == this.pageConfig.mustPlayback) { | ||
| this.played[_event.index] = true; | ||
| if (this.played.every(element => element === true)){ |
There was a problem hiding this comment.
Not sure, but I think the use of => is incorrect here...
There was a problem hiding this comment.
| if (this.played.every(element => element === true)){ | |
| if (this.played.every((element) => element === true)){ |
There was a problem hiding this comment.
I don't think this code was written by me. I'm happy to make the change, if you want me to, though. Please confirm.
There was a problem hiding this comment.
Yes, go a head. I discovered this using the grunt package task. You can check yourself if this solves the error.
I can try to enable this on github action in the future
There was a problem hiding this comment.
@nullpunktTUD i realized this is ES6 syntax, are you able to find and alternative that works on older browsers?
There was a problem hiding this comment.
Ok. I will look into this later
There was a problem hiding this comment.
Can you find an alternative for this?
There was a problem hiding this comment.
@Simon-Stone do you have an update on this? i'm not a js expert myself but maybe chatgpt could help here?
There was a problem hiding this comment.
I don't have an update, no. I can try to petition our AI overlords, though, and report back
Thank you for taking the time to consider the PR! I don't think there is anything missing and it seems to be working just fine. I'll try to resolve all your minor comments soon. |
Co-authored-by: Fabian-Robert Stöter <faroit@users.noreply.github.com>
|
Are there any changes left for me to make? |
|
Will look at this again end of the week |
|
this would be a super useful PR 😄 @nullpunktTUD Looks like you should add the pref test to |
|
This pull request is pretty old, but still useful! |
|
@fzalkow will discuss this with the license owners soon to move forward |
4 participants
DISCLAIMER: I am by no means a JavaScript programmer and I have cannibalized various other pages to clobber the new page together. I am absolutely certain that there the code could use some refactoring and cleanup, but I unfortunately do not have access to any experienced JavaScript programmers. If someone would take the time to do a proper code review of this PR, I would be happy to make any required changes, though.
I have a particular use case that was not covered by the current framework:
I want to compare a list different stimuli amongst itself in pairwise fashion. There is no reference or baseline, I simply want to compare every stimulus against every other stimulus and ask the subject which one they prefer. I also want to run the experiment online, possibly using crowdsourced participants, which means I need a way to discern who actually completed the experiment.
This PR adds several things to support this use case:
preference_test,All new features are documented in
experimenter.mdandparticipant.md.Two new YAML files
pref.yamlandpref_grouped.yamlare added toconfigs/to illustrate the use of the new page and options.Closes #88