Updated Plugin Headers #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 'Requires at least' to be 4.9.6 as the privacy tools are a requirement. Removed the Text Domain as we're requiring > 4.6 we don't require that header. Reference - https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#text-domains Note: We can also add the 'Requires PHP' header to indicate minimum PHP but I feel we have no specific requirements beyond what WP has so no need for that header.
I noticed that the readme.txt does define a minimum PHP so have added here as well.
Author
|
After reviewing the Readme.txt I realized we defined a required PHP there so might as well do so here too. |
Author
|
@audrasjb one other minor thing I noticed between the readme and plugin header is the license stuff. |
joldnl
reviewed
Feb 22, 2020
| * Author URI: https://jeanbaptisteaudras.com | ||
| * License: GPL-2.0+ | ||
| * License URI: http://www.gnu.org/licenses/gpl-2.0.txt | ||
| * Text Domain: gdpr-data-request-form |
There was a problem hiding this comment.
I don't agree removing this. I think this should serve as a reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'Requires at least' to be 4.9.6 as the privacy tools are a requirement.
Removed the Text Domain as we're requiring > 4.6 we don't require that header.
Reference - https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#text-domains
Note: We can also add the 'Requires PHP' header to indicate minimum PHP but I feel we have no specific requirements beyond what WP has so no need for that header.