Removes silent comparison, closes #449 #580
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the opposite of audreyfeldroy#579 If one isn't merged, the other should be.
Contributor
|
Whoops. My PR #584 includes this change too currently... I'll remove it from mine. I agree. I think this one should be merged. subprocess.check_call which is what is returned by |
Contributor
Author
|
Thanks for the PR. The project seems dead unmaintained so I've merged this PR and other in my fork https://github.com/AndreMiras/cookiecutter-pypackage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the opposite of #579
If one isn't merged, the other should be.