Skip to content

Added isort linter #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added isort linter #654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9402f7c
Added the option to use the isort linter along with flake8 and black.
polyglot-jones Mar 21, 2022
7407e89
Removed some code that slipped in by accident.
polyglot-jones Mar 21, 2022
a5f7d2f
Removed some more code that slipped in by accident.
polyglot-jones Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cookiecutter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"version": "0.1.0",
"use_pytest": "n",
"use_black": "n",
"use_isort": "n",
"use_pypi_deployment_with_travis": "y",
"add_pyup_badge": "n",
"command_line_interface": ["Click", "Argparse", "No command-line interface"],
Expand Down
6 changes: 5 additions & 1 deletion {{cookiecutter.project_slug}}/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.PHONY: clean clean-build clean-pyc clean-test coverage dist docs help install lint lint/flake8
{%- if cookiecutter.use_black == 'y' %} lint/black{% endif %}
{%- if cookiecutter.use_isort == 'y' %} lint/isort{% endif %}
.DEFAULT_GOAL := help

define BROWSER_PYSCRIPT
Expand Down Expand Up @@ -56,7 +57,10 @@ lint/black: ## check style with black
black --check {{ cookiecutter.project_slug }} tests
{%- endif %}

lint: lint/flake8{%- if cookiecutter.use_black == 'y' %} lint/black{%- endif %} ## check style
lint/isort: ## clean up all of the imports (using isort)
isort src tests

lint: lint/flake8{%- if cookiecutter.use_black == 'y' %} lint/black{%- endif %}{%- if cookiecutter.use_isort == 'y' %} lint/isort{%- endif %} ## check style

test: ## run tests quickly with the default Python
{%- if cookiecutter.use_pytest == 'y' %}
Expand Down
2 changes: 2 additions & 0 deletions {{cookiecutter.project_slug}}/requirements_dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@ Click==7.1.2{% endif %}
pytest==6.2.4{% endif %}
{% if cookiecutter.use_black == 'y' -%}
black==21.7b0{% endif %}
{% if cookiecutter.use_isort == 'y' -%}
isort{% endif %}