Skip to content

Fix Issue #670 : bake context argument should match the case #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Issue #670 : bake context argument should match the case #671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/test_bake_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ def test_bake_with_no_console_script(cookies):


def test_bake_with_console_script_files(cookies):
context = {'command_line_interface': 'click'}
context = {'command_line_interface': 'Click'}
result = cookies.bake(extra_context=context)
Comment on lines +272 to 273
Copy link

@CodiumAI-Agent CodiumAI-Agent Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: The 'command_line_interface' value in the context dictionary is case sensitive. It's better to use lower case to avoid potential issues with case sensitivity in the future.

Suggested change
context = {'command_line_interface': 'Click'}
result = cookies.bake(extra_context=context)
context = {'command_line_interface': 'click'}
result = cookies.bake(extra_context=context)

project_path, project_slug, project_dir = project_info(result)
found_project_files = os.listdir(project_dir)
Expand All @@ -281,7 +281,7 @@ def test_bake_with_console_script_files(cookies):


def test_bake_with_argparse_console_script_files(cookies):
context = {'command_line_interface': 'argparse'}
context = {'command_line_interface': 'Argparse'}
result = cookies.bake(extra_context=context)
Comment on lines +284 to 285
Copy link

@CodiumAI-Agent CodiumAI-Agent Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: The 'command_line_interface' value in the context dictionary is case sensitive. It's better to use lower case to avoid potential issues with case sensitivity in the future.

Suggested change
context = {'command_line_interface': 'Argparse'}
result = cookies.bake(extra_context=context)
context = {'command_line_interface': 'argparse'}
result = cookies.bake(extra_context=context)

project_path, project_slug, project_dir = project_info(result)
found_project_files = os.listdir(project_dir)
Expand All @@ -293,7 +293,7 @@ def test_bake_with_argparse_console_script_files(cookies):


def test_bake_with_console_script_cli(cookies):
context = {'command_line_interface': 'click'}
context = {'command_line_interface': 'Click'}
result = cookies.bake(extra_context=context)
Comment on lines +296 to 297
Copy link

@CodiumAI-Agent CodiumAI-Agent Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: The 'command_line_interface' value in the context dictionary is case sensitive. It's better to use lower case to avoid potential issues with case sensitivity in the future.

Suggested change
context = {'command_line_interface': 'Click'}
result = cookies.bake(extra_context=context)
context = {'command_line_interface': 'click'}
result = cookies.bake(extra_context=context)

project_path, project_slug, project_dir = project_info(result)
module_path = os.path.join(project_dir, 'cli.py')
Expand All @@ -314,7 +314,7 @@ def test_bake_with_console_script_cli(cookies):


def test_bake_with_argparse_console_script_cli(cookies):
context = {'command_line_interface': 'argparse'}
context = {'command_line_interface': 'Argparse'}
result = cookies.bake(extra_context=context)
Comment on lines +317 to 318
Copy link

@CodiumAI-Agent CodiumAI-Agent Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: The 'command_line_interface' value in the context dictionary is case sensitive. It's better to use lower case to avoid potential issues with case sensitivity in the future.

Suggested change
context = {'command_line_interface': 'Argparse'}
result = cookies.bake(extra_context=context)
context = {'command_line_interface': 'argparse'}
result = cookies.bake(extra_context=context)

project_path, project_slug, project_dir = project_info(result)
module_path = os.path.join(project_dir, 'cli.py')
Expand Down