Skip to content

chown the definitions to the rabbit user after our script edits them #3735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MoralCode merged 1 commit into from
Mar 4, 2026
+2 −1
Merged

chown the definitions to the rabbit user after our script edits them #3735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docker/rabbitmq/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ ARG RABBIT_MQ_DEFAULT_VHOST=augur_vhost
COPY --chown=rabbitmq:rabbitmq ./docker/rabbitmq/augur.conf /etc/rabbitmq/conf.d/

ADD docker/rabbitmq/definitions.json /etc/rabbitmq/
RUN chown rabbitmq:rabbitmq /etc/rabbitmq/definitions.json

ADD docker/rabbitmq/advanced.config /etc/rabbitmq/
RUN chown rabbitmq:rabbitmq /etc/rabbitmq/advanced.config
Expand All @@ -23,3 +22,5 @@ RUN apk add --no-cache python3
COPY docker/rabbitmq/update_config.py /

RUN exec python3 update_config.py

RUN chown rabbitmq:rabbitmq /etc/rabbitmq/definitions.json
Copy link
Copy Markdown
Collaborator

@sgoggins sgoggins Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the issue is that update_config.py cannot write to definitions.json ... just trying to wrap my head around whether or not this "should" work.

Given this error:

PermissionError: [Errno 13] Permission denied: '/etc/rabbitmq/definitions.json'
Error: building at STEP "RUN exec python3 update_config.py": while running runtime: exit status

it would seem like /etc/rabbitmq, if owned by the rabbitmq user, would then allow for the definitions.json file to be written.

I have not tested this, just thinking about the logic I see, @MoralCode .

Copy link
Copy Markdown
Collaborator

@sgoggins sgoggins Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would again seem to me that changing permissions on a file that can't be written won't work ... but this may be something I don't understand.

Copy link
Copy Markdown
Collaborator Author

@MoralCode MoralCode Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you asking?

Copy link
Copy Markdown
Collaborator Author

@MoralCode MoralCode Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the file can't be written due to permissions issues adjusting the permissions seems like it would help

Copy link
Copy Markdown
Collaborator

@sgoggins sgoggins Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the file already exist though?

Copy link
Copy Markdown
Collaborator Author

@MoralCode MoralCode Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's in the same folder as the Dockerfile. I think one of the previous Dockerfile steps is that we copy the file into the container before we run this script to make the final adjustments to it.

The problem here is essentially that if we run this chown line before we run the script that changes the file, we change the permissions such that the script can no longer edit the file, causing the crash.

I still need to run some builds with this new ordering of the build steps to make sure that the problem goes away, but I'm pretty confident that this is what's happening.

Copy link
Copy Markdown
Collaborator

@sgoggins sgoggins Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you comfortable its working?

Copy link
Copy Markdown
Collaborator Author

@MoralCode MoralCode Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Loading