Add INLINE or INLINABLE pragmas to all storable ranked code#19
Add INLINE or INLINABLE pragmas to all storable ranked code#19Mikolaj merged 8 commits intoaugustss:masterfrom
Conversation
Mikolaj
force-pushed
the
inlineable
branch
2 times, most recently
from
cdd0ce0 to
a2aa587
Compare
|
BTW, @augustss, is the comment orthotope/Data/Array/Internal.hs Line 170 in e64c77a about copying special cases from |
|
I don't remember what it refers to. |
Fair enough. I filed this as #20 for later so that it doesn't block this PR. |
But to make orthotope's fromList really usable, we'd need to copy https://git.tomsmeding.com/ox-arrays/tree/src/Data/Vector/Generic/Checked.hs?id=d1e2e280644baece2cabb075d566d99cc2c27019 here and use it instead, which would enable list streaming.
Data/Array/Internal.hs
Outdated
| constantT sh x = T (map (const 0) sh) 0 (vSingleton x) | ||
|
|
||
| -- TODO: change to return a list of vectors. | ||
| -- Convert an array to a vector in the natural order. |
There was a problem hiding this comment.
Update comment.
It might also be worth pointing out that an invariant is that if the input array is non-empty the returned list will have no empty vectors. The minimum/maximum oprations rely on this.
|
It looks good to me. |
|
Thank you. Comment updated and I've also brought back the internal If you don't object or beat me to it, I'd like to release 0.1.8.0 (non-breaking API additions) early next week. |
2 participants
and perform some other tweaks and fixes.