Skip to content

Conversation

@luadebug
Copy link
Member

@luadebug luadebug commented Aug 14, 2025

Resolves #542
Frame and it's border once collision appear next to ALabel scrolled down, Frame's border should taint ALabel.

@luadebug luadebug changed the title AGroupBox.cpp: Enforce title to trigger over TextOverflow and block c… AGroupBox.cpp: Enforce title to trigger over TextOverflow and block content text merge together with title text Aug 14, 2025
label->setTextOverflow(ATextOverflow::ELLIPSIS);
}
}
} << ".agroupbox-title",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to put both AOverflow::HIDDEN and ATextOverflow::ELLIPSIS to .agroupbox-title?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think should do a trick

Image

@luadebug luadebug requested a review from Alex2772 August 14, 2025 12:00
@Alex2772
Copy link
Collaborator

Does it really resolve #542 ?

@luadebug luadebug marked this pull request as draft August 31, 2025 17:00
@luadebug luadebug linked an issue Aug 31, 2025 that may be closed by this pull request
2 tasks
@luadebug luadebug added the design Architecture proposals label Aug 31, 2025
@luadebug luadebug closed this Oct 4, 2025
@luadebug luadebug reopened this Oct 4, 2025
@luadebug
Copy link
Member Author

luadebug commented Oct 4, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a rendering issue with AGroupBox by adjusting its stylesheet rules to fix how the title and frame interact, especially in overflow scenarios. The changes correctly enforce text clipping on the title and modify overflow properties for better visual consistency. The switch to a descendant selector (>>) for styling views within the title is a good, robust change. My only suggestion is to clean up a commented-out line that seems to be a leftover from debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design Architecture proposals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Render error

2 participants