-
Notifications
You must be signed in to change notification settings - Fork 40
AGroupBox.cpp: Enforce title to trigger over TextOverflow and block content text merge together with title text #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…ontent text merge together with title text
aui.views/src/AUI/View/AGroupBox.cpp
Outdated
| label->setTextOverflow(ATextOverflow::ELLIPSIS); | ||
| } | ||
| } | ||
| } << ".agroupbox-title", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried to put both AOverflow::HIDDEN and ATextOverflow::ELLIPSIS to .agroupbox-title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Does it really resolve #542 ? |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a rendering issue with AGroupBox by adjusting its stylesheet rules to fix how the title and frame interact, especially in overflow scenarios. The changes correctly enforce text clipping on the title and modify overflow properties for better visual consistency. The switch to a descendant selector (>>) for styling views within the title is a good, robust change. My only suggestion is to clean up a commented-out line that seems to be a leftover from debugging.

Resolves #542
Frame and it's border once collision appear next to ALabel scrolled down, Frame's border should taint ALabel.