Conversation
Summary of ChangesHello @Nelonn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's compression library dependency by switching from the standard Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully updates the zlib dependency to zlib-ng, which is a good step towards using a more modern and potentially faster compression library. The change involves updating the repository URL and the Git commit hash for the auib_import function. However, the CMAKE_ARGS for disabling example builds were removed, which might lead to unnecessary compilation of examples.
|
any chance to use the original repo instead of a fork? |
| for file in bin/*; do if [[ ! $file == bin/test_project ]]; then echo "Unexpected file: $file"; exit -1; fi; done | ||
| for file in lib/*; do if [[ ! $file =~ (\.so[\.0-9]*|lib/\*)$ ]]; then echo "Unexpected file: $file"; exit -1; fi; done | ||
| for file in lib/*; do | ||
| if [[ ! $file =~ (\.so([\.0-9]+)?(\..+)?)$ ]]; then |
There was a problem hiding this comment.
check the last pipeline. this is why my regex has lib/* in it
Patches are not supported in AUI.Boot. Using unmodified code in this case is not possible |
So there are arbitrary cmake fixes in your fork? By the way, patching in aui.boot by forking original repo is the intended way, so you are doing it right. |
Yep, I implemented some fixes related BUILD_SHARED_LIBS. Probably we can use original repo depending on which guarantees AUI.Boot provides about BUILD_SHARED_LIBS. Original cmake script doesn't allow undefined BUILD_SHARED_LIBS, only ON or OFF |
This reverts commit 2c2cbb1.
Updated the regex for validating shared library files to include zlib-ng and adjust the pattern.
2 participants
No description provided.