feat: adjust volume on wheel #186
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if feature patches like this are welcome, but I figured if I found it useful, others might. If not, feel free to close/delete this.
This patch replicates how Spotify behaves. When you hover the volume button and scroll your mouse wheel, the volume changes up/down. It's pretty simple, and copies the logic of ctrl+up/down.
I had a bit of trouble figuring out how to know when the player loaded, but I found the
window.Events.player.playerReadyevent useful. The renderer already subscribes to this, so I use that to add the mouse events. The actual slider is not a child of the button, so it requires 2 event subscribers. I use the aria-label to find the button - hopefully it's resistant to UI updates breaking the patch.