-
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix mobile navbar: remove inline styles and fix navigation IDs #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
3d86b40
32473cf
bce45a5
d9a5a73
cf6706b
47d3ecd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -307,6 +307,7 @@ nav ul { | |
| align-items: center; | ||
| flex-wrap: wrap; | ||
| gap: var(--spacing-md); | ||
| padding: 0; | ||
| } | ||
|
|
||
| nav li { | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -163,7 +163,7 @@ | |||||
| <a href="#main-content" class="skip-to-main">Skip to main content</a> | ||||||
|
|
||||||
| <nav style="margin-bottom:20px;"> | ||||||
| <ul style="list-style:none; padding:0; display:flex; justify-content:center; gap:30px; flex-wrap:wrap;"> | ||||||
| <ul style="list-style:none; padding:0;"> | ||||||
|
||||||
| <ul style="list-style:none; padding:0;"> | |
| <ul> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -128,7 +128,7 @@ | |||||
| <button class="mobile-menu-toggle" aria-label="Toggle navigation menu" aria-expanded="false" id="mobileMenuToggle"> | ||||||
| ☰ | ||||||
| </button> | ||||||
| <ul style="list-style:none; padding:0; display:flex; justify-content:center; gap:30px; flex-wrap:wrap;" id="platformNav"> | ||||||
| <ul style="list-style:none; padding:0;" id="platformNav"> | ||||||
|
||||||
| <ul style="list-style:none; padding:0;" id="platformNav"> | |
| <ul id="platformNav"> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -33,7 +33,7 @@ | |||||
| <button class="mobile-menu-toggle" aria-label="Toggle navigation menu" aria-expanded="false" id="mobileMenuToggle"> | ||||||
| ☰ | ||||||
| </button> | ||||||
| <ul style="list-style:none; padding:0; display:flex; justify-content:center; gap:30px; flex-wrap:wrap;" id="mainNav"> | ||||||
| <ul style="list-style:none; padding:0;" id="mainNav"> | ||||||
|
||||||
| <ul style="list-style:none; padding:0;" id="mainNav"> | |
| <ul id="mainNav"> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -34,7 +34,7 @@ | |||||
| <button class="mobile-menu-toggle" aria-label="Toggle navigation menu" aria-expanded="false" id="mobileMenuToggle"> | ||||||
| ☰ | ||||||
| </button> | ||||||
| <ul style="list-style:none; padding:0; display:flex; justify-content:center; gap:30px; flex-wrap:wrap;" id="mainNav"> | ||||||
| <ul style="list-style:none; padding:0;" id="mainNav"> | ||||||
|
||||||
| <ul style="list-style:none; padding:0;" id="mainNav"> | |
| <ul id="mainNav"> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -17,7 +17,7 @@ | |||||
| <button class="mobile-menu-toggle" aria-label="Toggle navigation menu" aria-expanded="false" id="mobileMenuToggle"> | ||||||
| ☰ | ||||||
| </button> | ||||||
| <ul style="list-style:none; padding:0; display:flex; justify-content:center; gap:30px; flex-wrap:wrap;" id="mainNav"> | ||||||
| <ul style="list-style:none; padding:0;" id="mainNav"> | ||||||
|
||||||
| <ul style="list-style:none; padding:0;" id="mainNav"> | |
| <ul id="mainNav"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inline styles
list-style:none; padding:0;are now redundant since the CSS rulenav ul(sentinel.css:303-311) already defines bothlist-style: noneandpadding: 0. These inline styles can be completely removed from all ul elements in the nav.