Fix security-scan workflow: replace deprecated --production with --om…#459
Merged
aurelianware merged 2 commits intomainfrom Mar 13, 2026
Merged
Fix security-scan workflow: replace deprecated --production with --om…#459aurelianware merged 2 commits intomainfrom
aurelianware merged 2 commits intomainfrom
Conversation
…it=dev The npm audit step failed because: 1. --production flag is deprecated (use --omit=dev) 2. The --json audit command had no --audit-level filter and no || true, causing bash -e to abort on any vulnerability finding https://claude.ai/code/session_01BvXfdVTKeUyN8PzhqspDVN
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions security scan workflow to adjust how npm audit is run (switching from --production to --omit=dev) and to persist audit output as an artifact.
Changes:
- Replace
npm audit --productionusage withnpm audit --omit=devin the Node dependency scan steps. - Attempt to generate and upload a JSON
npm auditreport artifact.
Comment on lines
+39
to
+40
| npm audit --omit=dev --audit-level=moderate | ||
| npm audit --omit=dev --audit-level=moderate --json > npm-audit.json || true |
Comment on lines
44
to
45
| if [ -d "services/claims-scrubbing-service" ]; then | ||
| cd services/claims-scrubbing-service |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…it=dev
The npm audit step failed because:
https://claude.ai/code/session_01BvXfdVTKeUyN8PzhqspDVN