Fix bug when sub-cycling a Hippo app#42
Closed
hsaunders1904 wants to merge 1 commit intoaurora-multiphysics:mainfrom
Closed
Fix bug when sub-cycling a Hippo app#42hsaunders1904 wants to merge 1 commit intoaurora-multiphysics:mainfrom
hsaunders1904 wants to merge 1 commit intoaurora-multiphysics:mainfrom
Conversation
The application would sometime enter an infinite loop when sub-cycling as MOOSE would never recognise that multiapps were synchronised. It was caused by cumulating numerical errors in the timestep size. This change attempts to prevent small numerical errors accumulating by preventing time step changes if the change is very small.
Collaborator
Author
|
Draft for now, as we need:
|
Collaborator
Author
|
I'm going to close this in favour of the work being done on #28. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The application would sometime enter an infinite loop when sub-cycling as MOOSE would never recognise that multiapps were synchronised. It was caused by accumulating numerical errors in the timestep size.
This change attempts to prevent small numerical errors accumulating by preventing time step changes if the change is very small.
Checklist