Fix openfoam build script#44
Merged
hsaunders1904 merged 2 commits intoaurora-multiphysics:mainfrom Mar 25, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the OpenFOAM build script.
In
b2b12c7I had removed a print statement from the OpenFOAM patch, however I had not updated the line ranges in the diff-block. This meant that the patch was not valid, and applying the patch would cause an error:error: corrupt patch at line 386.To fix, we revert
b2b12c7and instead of removing the print statement, we make it a blank line. I think this works within the flow of the function and means I don't have to manually update the diff-block's line range.Checklist