Skip to content

Update HeatFluxAux to use variable thermal conductivity#46

Merged
mattfalcone1997 merged 6 commits intoaurora-multiphysics:mainfrom
mattfalcone1997:material_heat_flux
Apr 29, 2025
Merged

Update HeatFluxAux to use variable thermal conductivity#46
mattfalcone1997 merged 6 commits intoaurora-multiphysics:mainfrom
mattfalcone1997:material_heat_flux

Conversation

@mattfalcone1997
Copy link
Collaborator

@mattfalcone1997 mattfalcone1997 commented Apr 23, 2025

Summary

This PR updates the HeatFluxAux by changing the input constant conductivity with an optional parameter diffusion_coefficient, which mirrors that in the HeatConduction kernel, with a default to the thermal_conductivity property set in the materials. The tests have been updated to reflect this change (by deleting the line specifying the thermal conductivity in the Auxkernel).

Related Issue

Resolves #23

Checklist

  • Tests have been updated
  • Verify comments/documentation updated to reflect changes.

@mattfalcone1997 mattfalcone1997 marked this pull request as ready for review April 23, 2025 11:12
Copy link
Collaborator

@hsaunders1904 hsaunders1904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me. It might be nice to have a test that checks the heat flux is actually changing over a varying k. It's a potentially non-trivial test to implement and I think this is a simple enough change that we could get a way without it. I'll leave it up to you!

@mattfalcone1997
Copy link
Collaborator Author

This all looks great to me. It might be nice to have a test that checks the heat flux is actually changing over a varying k. It's a potentially non-trivial test to implement and I think this is a simple enough change that we could get a way without it. I'll leave it up to you!

I think it would be best to have the test before we forget about it. I'll work it this week! Also, a good opportunity to work my way around the test system.

Copy link
Collaborator

@hsaunders1904 hsaunders1904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mattfalcone1997 mattfalcone1997 merged commit b3ba1b8 into aurora-multiphysics:main Apr 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow varying thermal conductivity in HeatFluxAux

2 participants