Update non-conformal tests to use analytical solutions#54
Merged
mattfalcone1997 merged 10 commits intoaurora-multiphysics:mainfrom Jun 24, 2025
Merged
Conversation
Collaborator
Author
|
The test should pass after the docker container is updated with the new requirements.txt. We could potentially update all the tests to use |
mattfalcone1997
force-pushed
the
nonconformal-tests
branch
2 times, most recently
from
885bc90 to
de7cde9
Compare
k-collie
reviewed
Jun 18, 2025
Collaborator
k-collie
left a comment
k-collie
left a comment
There was a problem hiding this comment.
Still reviewing, have these for now
mattfalcone1997
force-pushed
the
nonconformal-tests
branch
from
de7cde9 to
04984c5
Compare
k-collie
reviewed
Jun 23, 2025
Collaborator
k-collie
left a comment
k-collie
left a comment
There was a problem hiding this comment.
Everything looks good to me, just these two things I don't get
k-collie
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the non-conformal interface tests with polygonal, triangular and quadrilateral interfaces to use analytical solutions. It also changes the transfer type to
MultiAppGeneralFieldShapeEvaluationTransfer.Related Issue
Resolves #51
Checklist
pyvistato read OpenFOAM data, see Update requirements.test.txt so that the python unit tests can use vtk to read OpenFOAM data #53.