Skip to content

Implement backup and restore for fixed point iteration changes #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattfalcone1997 merged 86 commits into from
Jan 15, 2026
Merged

Implement backup and restore for fixed point iteration changes #65

mattfalcone1997 merged 86 commits into from
Jan 15, 2026

Conversation

@mattfalcone1997
Copy link
Collaborator

@mattfalcone1997 mattfalcone1997 commented Jul 11, 2025 •
edited
Loading

Summary

Implement backup and restore functionality for the data from OpenFOAM to allow fixed point iteration to be used with MOOSE. A potential advantage to be explored:

  • TFFB boundary coupling could be used with larger time steps by using Picard iteration to converge the boundary.
  • Allow more complex systems to be more tighly coupled

Maybe look to reproduce in the laplacianTestSolver

Related Issue

Resolves #21

Checklist

  • Implementation and testing for simple toy problems that check specific capabilties
    • Setting and resetting variables
    • ODEs
    • Boundary value problems
  • Unsteady heat conduction
    • Variable time step
    • Subcycling
  • Flow past a flat plate
    • Variable properties
    • Gravity
    • Full regression
  • Ensure simulations recoverable

@mattfalcone1997 mattfalcone1997 mentioned this pull request Jul 11, 2025
Closed
@mattfalcone1997 mattfalcone1997 force-pushed the implement_backup_and_restore branch from 3dc23f7 to 971b985 Compare August 8, 2025 15:17
@mattfalcone1997
Update latest fixed point changes
1fb7ede
@mattfalcone1997
Implement initial maybe working implementation
0391a3b
@mattfalcone1997
Update backup so it is placed in the FoamSolver class
c43c642
@mattfalcone1997
Update checkField to use method as the storeField functions
a1e01e8
@mattfalcone1997
Remove some asserts from FoamSolver
cb26764
@mattfalcone1997
Allow any OpenFOAM solver to be used inHippo
ec82603
@mattfalcone1997
Use new approach to copy OpenFOAM field data
778cc67
@mattfalcone1997
Clean up unused functions
afa732a
@mattfalcone1997
Move DataStore to separate file and move to problem
b088994
@mattfalcone1997
Add placeholder implementation of reconverable data with field read n…
d0dd8d4 
…ot implemented yet
@mattfalcone1997
Initial implementation of dataStore and dataLoad
bf1cb20
@mattfalcone1997
Implement dataStore/dataload as template
06a0242
@mattfalcone1997
Add serialisation/deserialisation for old time fields
0d47839
@mattfalcone1997
Update exodus data reader to removed deprecation warning
f705bb8
@mattfalcone1997
Add serial unsteady heat conduction test for fixed point
e1edb09
@mattfalcone1997
Implement simplified backup and restore
c901084
@mattfalcone1997
Fix simplified implementation
3418987
@mattfalcone1997
Remove uneeded FoamDataStore class
6dd1c88
@mattfalcone1997
simplify further dataStore/dataLoad templates
be766c1
@mattfalcone1997
Update field output method for testing
63bb028
@mattfalcone1997
Ensure new method gives same result as previous
64ff1b1
@mattfalcone1997
Optional allow storing of derived types
89d09f7
@mattfalcone1997
implement minor improvements to dataStore
00732e1
@mattfalcone1997
Ensure dataStore stream can fully hold double precision
a42f98a
@mattfalcone1997
Rremove unnecessary implementations of preBackup and postRestore
83c8b7c
@mattfalcone1997
Add initial implementation of OpenFOAM test modules for fixed-point i…
33fc8ba 
…teration
@mattfalcone1997
Fix Crank-Nicolson fixed-point for the internal fields
a834713
@mattfalcone1997
Implement simple function test for fixed-point
800b5a1
k-collie
k-collie reviewed Nov 10, 2025
View reviewed changes
Copy link
Collaborator

@k-collie k-collie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments before rebase and looking at tests

k-collie
k-collie reviewed Dec 9, 2025
View reviewed changes
@mattfalcone1997
Add debug code to print list of backed-up fields and mesh keys that a…
40904c9 
…re not backed up. Also make changes based on code review
@mattfalcone1997 mattfalcone1997 requested review from k-collie and removed request for k-collie January 8, 2026 16:04
k-collie
k-collie requested changes Jan 9, 2026
View reviewed changes
Copy link
Collaborator

@k-collie k-collie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to check the tests a bit but here's some comments.

k-collie
k-collie reviewed Jan 13, 2026
View reviewed changes
Copy link
Collaborator

@k-collie k-collie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look pretty good overall I think, just a few things.

k-collie
k-collie approved these changes Jan 15, 2026
View reviewed changes
Copy link
Collaborator

@k-collie k-collie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enduring my review Matt! Good job

@mattfalcone1997 mattfalcone1997 merged commit 44b15e8 into aurora-multiphysics:main Jan 15, 2026
2 checks passed
@mattfalcone1997 mattfalcone1997 deleted the implement_backup_and_restore branch January 15, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k-collie k-collie k-collie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement backup and restore

2 participants

@mattfalcone1997 @k-collie