Merge entire new transfer system in main #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattfalcone1997
requested review from
hsaunders1904
and removed request for
hsaunders1904
Collaborator
|
I think the example in the docs still needs updating to use the new syntax |
…adowing with basic test
…r variable shadowing
mattfalcone1997
force-pushed
the
generalise_bcs_transfer
branch
from
5c38ed2 to
a3a3753
Compare
Collaborator
Author
|
The error seems to come from the shell and tube mesh download that doesn't seem to exist anymore. I can add the mesh to the repo directly |
Co-authored-by: Harry Saunders <[email protected]>
…be meshes and license changes
hsaunders1904
approved these changes
Nov 10, 2025
|
|
||
| The regression test runs for 10 seconds, but to get a mostly converged solution, it is recommended that simulation the end time is changed to 500 by modifying `solid.i` and the `controlDict` files in `fluid_inner` and `fluid_outer`. | ||
| The regression test runs for 10 seconds, but to get a mostly converged solution, | ||
| it is recommended that simulation the end time is changed to 500 by modifying |
Collaborator
There was a problem hiding this comment.
Suggested change
| it is recommended that simulation the end time is changed to 500 by modifying | |
| it is recommended that the end time is changed to 500 by modifying |
Comment on lines
+15
to
+16
| from solid to fluid) coupling, meaning the solid is run transient. | ||
| To speed up convergence, the $c_p$ is decreased initially. |
Collaborator
There was a problem hiding this comment.
Suggested change
| from solid to fluid) coupling, meaning the solid is run transient. | |
| To speed up convergence, the $c_p$ is decreased initially. | |
| from solid to fluid) coupling, meaning the solid is run transient. | |
| To speed up convergence, the $c_p$ is decreased initially. |
| from solid to fluid) coupling, meaning the solid is run transient. | ||
| To speed up convergence, the $c_p$ is decreased initially. | ||
|
|
||
| `prep.sh` cleans the case, downloads and decompresses the meshes, and partitions the case. |
Collaborator
There was a problem hiding this comment.
It doesn't download any more, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merges all changes to transfer system into the main branch.
Related Issue
Resolves #43
Checklist