Implement postprocessors for OpenFOAM-based quantities #76

mattfalcone1997 · 2025-10-10T14:20:35Z

Summary

Implements two Postprocessors that create aggregate data directly from OpenFOAM data bypassing UserObject's initialize, execute, finalize methods but still being reported as Postprocessors. Unlike the parent issue, A FoamPostprocessors input syntax block has not been used.

Related Issue

Resolves #75

Checklist

Tests have been written for the new/changed behaviour.
Documentation/examples have been added/updated for the new changes.
Await merge of Variable/BC system (I should have created this from main :(

…oam Postprocessor

k-collie · 2026-01-19T17:07:15Z

src/postprocessors/FoamPostprocessorBase.C

+}
+
+void
+FoamPostprocessorBase::threadJoin(const UserObject & uo)


[[maybe_unused]]

k-collie

First set of comments to keep you busy

k-collie · 2026-01-20T11:11:10Z

src/postprocessors/FoamPostprocessorBase.C

+void
+FoamPostprocessorBase::threadJoin(const UserObject & uo)
+{
+  (void)uo;


[[maybe_unused]]

k-collie · 2026-01-20T11:12:35Z

test/OpenFOAM/modules/postprocessorTestSolver/postprocessorTestSolver.H

+    Solver module for to test transfers between OpenFOAM and MOOSE. Based on Solid
+    solver


Update description

k-collie · 2026-01-20T15:21:46Z

test/tests/postprocessors/side_advective_flux_integral/main.i

+        foam_scalar = 'rho'
+        boundary = front
+    []
+[]


Since FoamSideAdvectiveFluxIntegral can take multiple boundaries maybe you should add one that does two added together?

k-collie · 2026-01-20T16:37:16Z

test/tests/postprocessors/side_average/main.i

+        boundary = right
+        component = z
+        execute_on = TIMESTEP_END
+    []


Same here - would be good to test one with multiple boundaries

k-collie · 2026-01-20T16:37:29Z

test/tests/postprocessors/side_integrated_value/main.i

+        boundary = right
+        component = x
+        execute_on = TIMESTEP_END
+    []


And here - multiple boundaries

k-collie · 2026-01-29T11:53:29Z

src/postprocessors/FoamSideIntegratedValue.C

+        new Foam::functionObjects::wallShearStress("wallShearStress", _foam_mesh->time(), fo_dict));
+  }
+
+  _function_object->execute();


Add a comment explaining with this execute is needed.

k-collie · 2026-01-29T11:54:50Z

src/postprocessors/FoamSideIntegratedValue.C

+}
+
+void
+FoamSideIntegratedValue::createFunctionObject()


I wonder if it would be cleaner to move the _pp_function_objects check into this method.

k-collie · 2026-01-29T11:57:48Z

include/postprocessors/FoamSideIntegratedValue.h

+
+static MooseEnum _pp_function_objects("wallHeatFlux wallShearStress");
+
+class FoamSideIntegratedValue : public FoamSidePostprocessor


What would you think about splitting this class into FoamSideIntegratedFunctionObject and FoamSideIntegratedValue? It feels like this class is doing 2 things - maybe the common functionality could be put into a shared base class or some class you compose.

I think this is a good idea

k-collie · 2026-01-29T11:59:51Z

src/postprocessors/FoamSideAverageValue.C

+  // sum over ranks
+  gatherSum(volume);
+
+  // divide by area
+  _value /= volume;


I don't really like how this updates _value computed from FoamSideIntegratedValue::compute, maybe we could design this away.

I was just trying to match the implementation used in MOOSE, but I agree, I will change it

k-collie · 2026-01-29T12:02:29Z

src/postprocessors/FoamSideAverageValue.C

+    }
+  }
+  // sum over ranks
+  gatherSum(volume);


Let's call it area instead of volume

object

mattfalcone1997 force-pushed the implement-foampostprocessor branch from 13a5bf2 to 181c4d9 Compare November 16, 2025 10:08

mattfalcone1997 added 27 commits January 16, 2026 09:34

Add FoamPostprocessor base class

3aab0c2

Add test FoamPostprocessor for input syntax

3c30f86

Add input syntax test for FoamPostprocessors

34a58e1

Use BlockRestrictable base class for FoamPostprocessor

da0b2c0

Update tests to include boundaries

c242915

Add initial side average foam postprocessor

3212f1e

Create working side average postprocessor

b812998

Remove unnecessary action tests

dbee885

Add postprocessor test solver

f274432

Make use of current element info in postprocessor

b3bfff1

Add test for FoamSideAverageValue postprocessor

acfbcd6

Updated FoamProcessor so it computes with FoamProblem

0c9d93e

Add table for Foam Postprocessors

ab557d8

Add additional error checks to exisiting Foam Postprocessors

3823599

Update Postprocessor test solver to be based on fluid solver

af701b7

Update side average test to use fluid-based solver

8f8792d

Add advective flux postprocessor for calculating mass flux

18dc1b3

Add tests for FoamSideAdvectiveFluxIntegral

02f1b4e

Update side average so components of vectors can used

aa6af7f

Improve comments for foam postprocessors

2491921

Add parallel tests for postprocessors

243e9e8

Remove FoamPostprocessor block after rebase

ffc896f

Apply git patch from postprocessor BC branch to get all updates for F…

4a704f3

…oam Postprocessor

Update after initial review of source

2a52b95

Add separate tests for average and integrated flux postprocessors

192f2d5

Add test for invalid scalars for advective flux integral postprocessor

81fd65b

Add test for wallHeatFlux (using function objects)

efa55c4

mattfalcone1997 force-pushed the implement-foampostprocessor branch from 181c4d9 to efa55c4 Compare January 16, 2026 15:45

mattfalcone1997 marked this pull request as ready for review January 16, 2026 15:46

mattfalcone1997 requested a review from k-collie January 16, 2026 15:46

Fix file ends in foam_modules.mk

a783bd9

k-collie reviewed Jan 19, 2026

View reviewed changes

k-collie reviewed Jan 29, 2026

View reviewed changes

mattfalcone1997 added 11 commits January 29, 2026 13:31

Incorporate initial review changes

1110245

Add tests for multiple boundaries for side advective flux integral

d99f673

Add tests for multiple boundaries for side average value

732c092

Add tests for multiple boundaries for side integrated value

5cae496

Refactor integrated postprocessors to separate value from function

4637d20

object

Add average postprocessors for function objects

521cd59

Update integrated value tests

192dc99

Add tests for average function object postprocessors

aaac42d

Add test to check function object is valid

2e8b293

Move Foam includes from postprocessors to fvCFD_moose.h

b180c1d

Remove unnecessary includes

25756c4

		Solver module for to test transfers between OpenFOAM and MOOSE. Based on Solid
		solver


		static MooseEnum _pp_function_objects("wallHeatFlux wallShearStress");

		class FoamSideIntegratedValue : public FoamSidePostprocessor

Implement postprocessors for OpenFOAM-based quantities #76

Are you sure you want to change the base?

Implement postprocessors for OpenFOAM-based quantities #76

Uh oh!

Conversation

mattfalcone1997 commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issue

Checklist

Uh oh!

k-collie Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k-collie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mattfalcone1997 commented Oct 10, 2025 •

edited

Loading

k-collie Jan 19, 2026 •

edited

Loading