feat: Replaced generated code with stellar-xdr#17
Merged
bjorn merged 1 commit intoaurora-rs:masterfrom Nov 19, 2025
Merged
Conversation
Collaborator
Author
|
@fracek I think I'm going a little crazy doing this change. |
060133d to
efedaf5
Compare
efedaf5 to
f7ef256
Compare
Removed the dependencies xdr-rs-serialize and xdr-rs-serialize-derive, since serialization is already provided by stellar-xdr. For compatibility reasons and convenience, the existing XDRSerialize and XDRDeserialize traits are now implemented on top of the WriteXdr and ReadXdr traits from stellar-xdr. Added a bunch of new data types and enum values. Removed enum types where they added nothing beyond the same type in stellar-xdr. No support was added for Preconditions::V2 and TransactionExt::V1, both part of the new stellar_xdr_curr::Transaction type. When trying to convert transactions which use these values an UnsupportedFeature error is returned for now. Also, not all new types have been wrapped. For example, the inner data of the new LedgerKey values instead refers directly to the types from the stellar-xdr crate. This can be changed when there is demand, but it seems futile to wrap all these types in verbose API and to keep this updated. Closes aurora-rs#10 Signed-off-by: Thorbjørn Lindeijer <bjorn@lindeijer.nl>
f7ef256 to
4f4279d
Compare
Collaborator
Author
|
OMG, it compiles and all tests pass! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 65.77% 65.53% -0.24%
==========================================
Files 43 45 +2
Lines 3795 3839 +44
==========================================
+ Hits 2496 2516 +20
- Misses 1299 1323 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the dependencies
xdr-rs-serializeandxdr-rs-serialize-derive, since serialization is already provided bystellar-xdr.For compatibility reasons and convenience, the existing
XDRSerializeandXDRDeserializetraits are now implemented on top of theWriteXdrandReadXdrtraits fromstellar-xdr.Added a bunch of new data types and enum values. Removed enum types where they added nothing beyond the same type in
stellar-xdr. Not all new types have been wrapped. For example, the inner data of the new LedgerKey values instead refers directly to the types from thestellar-xdrcrate. This can be changed when there is demand, but it seems futile to wrap all these types in verbose API and to keep this updated.No support was added for
Preconditions::V2andTransactionExt::V1, both part of the newstellar_xdr_curr::Transactiontype. When trying to convert transactions which use these values an UnsupportedFeature error is returned for now.Closes #10