Skip to content

UPSTREAM PR #1994: Implement ABSL_HASH_INTERNAL_CRC32_U64 for x86 builds #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loci-dev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

UPSTREAM PR #1994: Implement ABSL_HASH_INTERNAL_CRC32_U64 for x86 builds #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions absl/hash/internal/hash.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,16 @@
#include <filesystem> // NOLINT
#endif

// 32-bit builds with SSE 4.2 do not have _mm_crc32_u64, so the
// __x86_64__ condition is necessary.
#if defined(__SSE4_2__) && defined(__x86_64__)
#if defined(__SSE4_2__)

#include <x86intrin.h>
#define ABSL_HASH_INTERNAL_HAS_CRC32
#if defined(__x86_64__)
#define ABSL_HASH_INTERNAL_CRC32_U64 _mm_crc32_u64
#else
#define ABSL_HASH_INTERNAL_CRC32_U64(crc, v) \
_mm_crc32_u32(_mm_crc32_u32((uint32_t)crc, (uint32_t)v), (uint32_t)(v >> 32))
#endif
#define ABSL_HASH_INTERNAL_CRC32_U32 _mm_crc32_u32
#define ABSL_HASH_INTERNAL_CRC32_U8 _mm_crc32_u8

Expand All @@ -109,7 +112,12 @@
// MSVC AVX (/arch:AVX) implies SSE 4.2.
#include <intrin.h>
#define ABSL_HASH_INTERNAL_HAS_CRC32
#if defined (_M_X64)
#define ABSL_HASH_INTERNAL_CRC32_U64 _mm_crc32_u64
#else
#define ABSL_HASH_INTERNAL_CRC32_U64(crc, v) \
_mm_crc32_u32(_mm_crc32_u32((uint32_t)crc, (uint32_t)v), (uint32_t)(v >> 32))
#endif
#define ABSL_HASH_INTERNAL_CRC32_U32 _mm_crc32_u32
#define ABSL_HASH_INTERNAL_CRC32_U8 _mm_crc32_u8

Expand Down