UPSTREAM PR #16816: [bug fix] initialise buffer.device in ggml_hexagon_session #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DajanaV
force-pushed
the
main
branch
4 times, most recently
from
1983956 to
326a60a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#16816
It seems
buffer_type.deviceandrepack_buffer_type.deviceremains uninitialised.This causes an sporadic crash at
ggml_backend_dev_get_props(dev, &props);atllama-model.cpp:6184.I believe
ggml_hexagon_sessionshould always be initialised with the device it corresponds to?The original code works fine when ran via the cli, however, the crash becomes apparent when bundled into a consumer facing APK.
This fix is tested to fix this issue (running from packaged APK, S25+ Ultra)