Skip to content

Conversation

@loci-dev
Copy link

@loci-dev loci-dev commented Dec 4, 2025

Mirrored from ggml-org/llama.cpp#17765

Make sure to read the contributing guidelines before submitting a PR

Add a search field to the model selector / Improve mobile display / Simplify the code

1 2 3 4

Close #17741

@loci-agentic-ai
Copy link

Explore the complete analysis inside the Version Insights

Performance Analysis Summary - PR #438

Analysis Overview

This PR introduces frontend-only modifications to the llama-server web interface, specifically adding search functionality to the model selector dropdown and improving mobile display responsiveness. The changes affect 3 files: a Svelte component, a TypeScript constants file, and a compiled HTML artifact.

Performance Impact

No performance impact on inference operations. All modifications are isolated to the web UI layer with zero changes to core inference binaries or functions. The power consumption analysis confirms stable performance across all backend components:

  • libllama.so: 194,027 nJ (0 nJ change)
  • libggml-cpu.so: 117,027 nJ (0 nJ change)
  • libggml-base.so: 59,071 nJ (0 nJ change)
  • llama-run: 218,706 nJ (0 nJ change)

Tokens per second: Unaffected. No changes to llama_decode, llama_encode, or llama_tokenize functions. Response time and throughput for inference operations remain unchanged.

Binary-level changes: Two binaries show complete removal (llama-cvector-generator: -249,105 nJ, llama-tts: -253,822 nJ), but these are unrelated to this PR and represent separate build configuration changes in the version comparison.

The PR adds client-side search filtering with O(n) complexity per keystroke, which is negligible for typical model counts and occurs entirely in the browser without backend interaction.

@loci-dev loci-dev force-pushed the main branch 5 times, most recently from 4ba0a8d to 4587bfa Compare December 5, 2025 11:09
Several structural & UX improvements for Models Selector component
@loci-dev loci-dev force-pushed the main branch 7 times, most recently from a73de67 to df48f9e Compare December 6, 2025 11:06
Use Floating UI's auto-positioning with 50dvh height limit and proper
collision detection instead of forcing top positioning. Fixes overflow
on desktop and mobile keyboard issues
@loci-dev loci-dev force-pushed the main branch 2 times, most recently from cb46586 to 1a14b3a Compare December 6, 2025 13:13
Place search at the 'near end' (closest to trigger) by swapping layout
with CSS flexbox order based on popover direction. Prevents input from
moving during typing as list shrinks
@loci-dev loci-dev force-pushed the main branch 8 times, most recently from 84f6117 to 91eb894 Compare December 7, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants