-
Notifications
You must be signed in to change notification settings - Fork 0
UPSTREAM PR #17765: Add a search field on model selector / improve mobile display #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
UPSTREAM PR #17765: Add a search field on model selector / improve mobile display #438
Conversation
|
Explore the complete analysis inside the Version Insights Performance Analysis Summary - PR #438Analysis OverviewThis PR introduces frontend-only modifications to the llama-server web interface, specifically adding search functionality to the model selector dropdown and improving mobile display responsiveness. The changes affect 3 files: a Svelte component, a TypeScript constants file, and a compiled HTML artifact. Performance ImpactNo performance impact on inference operations. All modifications are isolated to the web UI layer with zero changes to core inference binaries or functions. The power consumption analysis confirms stable performance across all backend components:
Tokens per second: Unaffected. No changes to Binary-level changes: Two binaries show complete removal (llama-cvector-generator: -249,105 nJ, llama-tts: -253,822 nJ), but these are unrelated to this PR and represent separate build configuration changes in the version comparison. The PR adds client-side search filtering with O(n) complexity per keystroke, which is negligible for typical model counts and occurs entirely in the browser without backend interaction. |
4ba0a8d to
4587bfa
Compare
Several structural & UX improvements for Models Selector component
a73de67 to
df48f9e
Compare
Use Floating UI's auto-positioning with 50dvh height limit and proper collision detection instead of forcing top positioning. Fixes overflow on desktop and mobile keyboard issues
cb46586 to
1a14b3a
Compare
Place search at the 'near end' (closest to trigger) by swapping layout with CSS flexbox order based on popover direction. Prevents input from moving during typing as list shrinks
84f6117 to
91eb894
Compare
Mirrored from ggml-org/llama.cpp#17765
Make sure to read the contributing guidelines before submitting a PR
Add a search field to the model selector / Improve mobile display / Simplify the code
Close #17741